Just ran phpcs on module.
Has lots of inconsistencies. Will fix and upload the patch.

CommentFileSizeAuthor
#6 auto_entitylabel-fix_pareview_items_2826975_2.patch20.7 KBrenatog
#2 auto_entitylabel-phpcs_fix-2826975-2-D8.patch18.35 KBvladimiraus

Comments

VladimirAus created an issue. See original summary.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
StatusFileSize
new auto_entitylabel-phpcs_fix-2826975-2-D8.patch18.35 KB

Note, that was created after applying https://www.drupal.org/node/2712441#comment-11759022 patch

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Needs review
peacog’s picture

peacog commented
Parent issue: » #2659636: [Meta] D8 Port of Automatic Entity Label (AEL) Module
peacog’s picture

peacog commented
Status: Needs review » Needs work

Will need re-roll when #2755445: Auto Entity label does not set entity labels and breaks contrib modules is committed

renatog’s picture

renatog commented
StatusFileSize
new auto_entitylabel-fix_pareview_items_2826975_2.patch20.7 KB

Thank you very much guys.

@vladimiraus, i create new patch because code was updated.

The patch with fix it's in attachment.

  • RenatoG committed 9e36455 on 8.x-1.x 
    Issue #2826975 by VladimirAus, RenatoG, Peacog: PHPCS errors
renatog’s picture

renatog commented
Assigned: vladimiraus » Unassigned
Status: Needs work » Fixed
Issue tags: +ciandt-contrib

Fixed.

Commited in dev branch.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.