Problem/Motivation

Based on numerous reasons, but more recently motivated by #2767643: Scalar to array migration returns NULL , we need more solid test coverage for process plugins. Let's do that in two stages. First, add a base kernel test base class. Follow that up with follow ups for specific plugins. First being the Migration plugin.

Proposed resolution

Write code

Remaining tasks

Write code, modeled off the source plugin KTB.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 create_a_ktb_for-2826638-5.patch19.46 KBheddn
#5 create_a_ktb_for-2826638-5.patch19.46 KBheddn
#3 create_a_ktb_for-2826638-3.patch19.46 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Priority: Normal » Major
Issue tags: +Migrate critical

Lots of important dependencies are blocked by this. Bumping priority and adding the migrate critical tag. If another maintainer feels that is too high a priority, feel free to remove it.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new create_a_ktb_for-2826638-3.patch19.46 KB

Here's a stub without any tests (yet). Want to see if I broke anything before I continue with refactoring things.

Status: Needs review » Needs work

The last submitted patch, 3: create_a_ktb_for-2826638-3.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
StatusFileSize
new create_a_ktb_for-2826638-5.patch19.46 KB
new create_a_ktb_for-2826638-5.patch19.46 KB

Oops. Let's name that class correctly.

benjy’s picture

benjy commented

I don't think improving our testing base classes should be critical or blocking any other issues. Those issues are free to unit test process plugins like we have for the last few years or add a KTB test without a nice to have base class.

The last submitted patch, 5: create_a_ktb_for-2826638-5.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: create_a_ktb_for-2826638-5.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: -Migrate critical

Removing critical. It was a bit premature to add it. Also, I have a couple examples of what a base KTB for process plugins could look like over in #2809793: EntityReference migrate destination.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Closed (won't fix)

I think I was imagining this was going to be harder. We can and do have KTB process tests now that do not need a base plugin.