After i installed Style Guide module i have this error:

Twig_Error_Loader: Template "@theme/components/highlight-mark.twig" is not defined (Drupal\Core\Template\Loader\ThemeRegistryLoader: Unable to find template "@my_theme/components/highlight-mark.twig" in the Drupal theme registry.) in "profiles/my_name/themes/my_theme/templates/content/mark.html.twig" at line 16. in Twig_Loader_Chain->getCacheKey() (line 115 of /var/www/html/vendor/twig/twig/lib/Twig/Loader/Cha

CommentFileSizeAuthor
#10 highlight-mark-with-styleguide-2826606-10.patch1.18 KBandypost
#7 highlight-mark-with-styleguide-2826606-7.patch682 bytesandypost
#2 interdiff-2826606-1.txt1.23 KBhog
#2 highlight-mark-with-styleguide-2826606-1.patch1.05 KBhog

Comments

HOG created an issue. See original summary.

hog’s picture

hog commented
StatusFileSize
new highlight-mark-with-styleguide-2826606-1.patch1.05 KB
new interdiff-2826606-1.txt1.23 KB

Highlight-mark component was't included correct.

hog’s picture

hog commented
Status: Needs work » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/STARTERKIT/STARTERKIT.info.yml
@@ -63,6 +63,7 @@ libraries:
+  - STARTERKIT/highlight-mark

Are you sure this library should be attached to every page?

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work

Please fix only component usage

PS: http://cgit.drupalcode.org/zen/tree/STARTERKIT/components/components/hig...

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented 
  1. +++ b/STARTERKIT/STARTERKIT.info.yml
@@ -63,6 +63,7 @@ libraries:
+  - STARTERKIT/highlight-mark

    I agree with andypost, the library is added by the highlight-mark.twig file. No need to add it to every page. 

  2. +++ b/STARTERKIT/templates/content/mark.html.twig
@@ -13,7 +13,7 @@
     {% include "@STARTERKIT/components/highlight-mark.twig" with {content: 'Updated'|t} only %}

    We need to fix this line as well.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new highlight-mark-with-styleguide-2826606-7.patch682 bytes

It's pretty annoying, so here's a proper patch

hog’s picture

hog commented

Dudes, i think it's the same as other libraries as attached on info file. Not all are always on page. But i think base styles always must be attached. Because i think we need to put highlight-mark in info file.

andypost’s picture

andypost
he/him
Primary language Russian
commented

@Sergiy Good point, mark template defined by system module

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new highlight-mark-with-styleguide-2826606-10.patch1.18 KB

So both fixed

hog’s picture

hog commented
Issue summary: View changes
hog’s picture

hog commented
Status: Needs review » Reviewed & tested by the community

#10 patch is ok.