Closed (fixed)
Project:
Max Image Size
Version:
7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Nov 2016 at 20:22 UTC
Updated:
1 Jul 2017 at 14:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sushylI think this patch could fix the bug.
Comment #3
steven.wichers commentedThis is a duplicate of https://www.drupal.org/node/2693499
Nobody is able to provide directions to reproduce the issue on a clean install or point to specific modules causing the issue. Nothing in the code refers to max_image_size_variable_settings_form_submit, so it is an incompatibility with a contrib module.
The patch provided more works around the issue by not figuring out why an additional submit handler is breaking and instead just putting the code elsewhere.
Comment #4
pasqualleThe bug is caused by the variable module
In variable_form_alter() the module alters the form submit function.
see: http://cgit.drupalcode.org/variable/tree/variable.module#n689
I am not sure if the variable_form_alter() function is correct, but changing the max_image_size_system_settings_form() function name (and its submit function) to something else should fix this issue.
Comment #5
pasqualleComment #7
steven.wichers commentedThanks Pasqualle, at first glance that does look like the culprit. I'll put some time on this a bit later to see if there's a better solution but if not I'll merge your patch.
Comment #8
anybodyRTBC. Please apply and create a new stable relase to fix the settings page. The patch is perfect.
Comment #10
steven.wichers commentedI'm comfortable with renaming the function now that the root cause has been identified.
Comment #11
anybodyThank you very much! :)