Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Brightcove itself supports a name of 255 character. For some, unknown, reason though, the brightcove module limits the field to 60 characters, which could be easily not enough.
Proposed resolution
Enlarge it to 255 characters.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 2826265-10.patch | 3.38 KB | dawehner |
| #9 | 2826265-9.patch | 3.38 KB | dawehner |
| #2 | 2826265-2.patch | 1.4 KB | dawehner |
Comments
Comment #2
dawehnerThere we go.
Comment #3
yce CreditAttribution: yce at Pronovix for BrightCove commented@dawehner But it's not limited to 60 characters, the max_length for the name field on the Video entity is not even defined.
We left it undefined because we wanted to use the Drupal's default which is 255 characters.
Comment #4
dawehner@yce
Please checkout the database schema. It certainly had a maximum length of 60 here.
Comment #5
dawehnerThank you for responding that quickly.
You probably just wanted to configure the textfield widget, right? See
\Drupal\Core\Field\Plugin\Field\FieldWidget\StringTextfieldWidgetComment #6
yce CreditAttribution: yce at Pronovix for BrightCove commentedAh okay, I see now, we forgot the update hook to update the schema, thanks!
Can you create a patch only for that?
Also why varchar_ascii? Why not simply varchar?
I think we don't want that for the name field.
I the meantime if you run the
drupal update:entitiescommand it will update the schema.Comment #7
dawehnerGood point
Comment #8
dawehnerOH I just realized we are running on an old version of the module, with way too many patches applied.
Comment #9
dawehnerWe don't need the update path I guess? Well, here is a patch just for my installation, but yeah let's close the issue. You've already fixed it. Sorry for the noise.
Comment #10
dawehnerComment #11
jan.mashat CreditAttribution: jan.mashat at Pronovix for BrightCove commented"it seems there is no way to provide an upgrade path that keeps all your data."
https://www.drupal.org/node/2766697
Comment #12
dawehner@jan.mashat
I'm pretty sure the update path which was included as part of the patch above, should fix that as expected. This is AFAIK the recommended way to update database schema and so forth, when there is already production data. There is no automation, because that would be simply too hard to write.