Between 800-1100px viewport width, the modal is incorrectly sized; it's wider than the page, so you cannot see the X button to close it.

CommentFileSizeAuthor
#4 screenshot_after.png202.86 KBsanja_m
#4 screenshot_before.png204.54 KBsanja_m
#2 modal_wider_than_viewport-2826010-2.patch1.01 KBamoebanath

Comments

amoebanath created an issue. See original summary.

amoebanath’s picture

amoebanath commented
Assigned: amoebanath » Unassigned
Status: Active » Needs review
StatusFileSize
new modal_wider_than_viewport-2826010-2.patch1.01 KB

Looks like we just want < rather than > :)

slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work
Issue tags: +D8Media

Please add before and after screenshot.

sanja_m’s picture

sanja_m commented
Status: Needs work » Needs review
StatusFileSize
new screenshot_before.png204.54 KB
new screenshot_after.png202.86 KB

I was able to reproduce this bug on chrome at about 830px viewport width, this patch fixes it, and here are screenshots before and after applying this patch.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Removed the extra newline at the end of file. Committed. Thanks!

  • slashrsm committed c66f758 on 8.x-1.x authored by amoebanath 
    Issue #2826010 by amoebanath, sanja_m: Make sure modal is never wider...
scm6079’s picture

scm6079 commented

(EDIT) Just went to fix this, and see there is a patch in place with related issue: 2828023

This patch breaks responsive support! The dialog width is supposed to allow for an "Empty value for responsive width"; however, if you don't enter a value you will always end up with wWidth being greater than the configured width, and will break the option. It's imperative that either this patch is reverted or adjusted to take into account the dialog.options.maxWidth not being set.

As it stands now, enabling responsive support (no width/height set) will cause the dialog to break.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.