The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The \Drupal\migrate\Plugin\migrate\process\Migration class uses a $migration property but the property is not part of the class definition. It should be.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | migrate-2825088-2.patch | 1.19 KB | xjm |
| #2 | migration_property_not-2825088-2.patch | 1.19 KB | kasperg |
Comments
Comment #2
kasperg commentedHere is a simple patch, which adds the property definition.
Comment #3
cilefen commentedComment #4
xjmThanks @kasperg, good catch!
This is technically changing the visibility of this property from public to protected (yep, how annoying that undeclared properties are public by default). I confirmed in my IDE that there are no core usages outside this class, but technically, it's a BC break.
However, since migrate is still almost-but-not-quite in beta, we are okay to make this change in 8.3.x without a BC layer and in 8.2.x as well. (See #2810347: [policy, no patch] Mark migrate.module as beta stability.)
For some reason there is not a passing test run attached to this patch, so reuploading it for a test run before committing.
Comment #7
xjmCommitted 408f21e and pushed to 8.3.x and 8.2.x. Thanks!