Follow-up to #2776235: Cached autoloader misses cause failures when missed class becomes available: MigrateSourcePluginManager::$classLoader is unsed now and should be removed to avoid confusion.

CommentFileSizeAuthor
#3 2824868-3.patch571 byteshardikpandya

Comments

klausi created an issue. See original summary.

klausi’s picture

Issue tags: +Novice
hardikpandya’s picture

Status: Active » Needs review
StatusFileSize
new571 bytes

Added Patch

mikeryan’s picture

Status: Needs review » Reviewed & tested by the community

Ayup.

  • xjm committed a772a40 on 8.3.x
    Issue #2824868 by hardik.p, klausi: MigrateSourcePluginManager::$...
xjm’s picture

Version: 8.3.x-dev » 8.2.x-dev
Status: Reviewed & tested by the community » Fixed

I confirmed that this is the only reference to this property in Migrate, and that it is never set:

[mandelbrot:maintainer | Fri 17:05:52] $ grep -rl "classLoader" * | grep -v "vendor"
core/lib/Drupal/Core/DrupalKernel.php
core/modules/migrate/src/Plugin/MigrateSourcePluginManager.php
core/modules/simpletest/src/TestDiscovery.php
core/modules/simpletest/src/WebTestBase.php
core/tests/Drupal/KernelTests/KernelTestBase.php
core/tests/Drupal/Tests/BrowserTestBase.php
[mandelbrot:maintainer | Fri 17:05:57] $ grep -r "classLoader" core/modules/migrate/src/Plugin/MigrateSourcePluginManager.php
core/modules/migrate/src/Plugin/MigrateSourcePluginManager.php:  protected $classLoader;

So we should indeed remove the property. This fix is also needed in 8.2.x. Since the property is protected, it is internal API, and since it is already removed without BC in 8.2.x, it does not make sense to retain the documentation of it in 8.2.x either.

Committed a772a40 and pushed to 8.3.x and 8.2.x. Thanks!

  • xjm committed a9a7697 on 8.2.x
    Issue #2824868 by hardik.p, klausi: MigrateSourcePluginManager::$...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.