The d6_cck_file process plugin has a catch for MigrateSkipRowException from the migration process plugin - which no longer throws that exception. The try/catch should be removed.

CommentFileSizeAuthor
#5 remove_obsolete-2824444-5.patch1.25 KBada hernandez
#3 remove_obsolete-2824444-3.patch1.53 KBada hernandez

Comments

mikeryan created an issue. See original summary.

ada hernandez’s picture

ada hernandez commented
Assigned: Unassigned » ada hernandez
ada hernandez’s picture

ada hernandez commented
Status: Active » Needs review
StatusFileSize
new remove_obsolete-2824444-3.patch1.53 KB

removed!

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Needs work 
+++ b/core/modules/file/src/Plugin/migrate/process/d6/CckFile.php
@@ -70,23 +70,7 @@ public static function create(ContainerInterface $container, array $configuratio
-    // Try to look up the ID of the migrated file. If one cannot be found, it
-    // means the file referenced by the current field item did not migrate for
-    // some reason -- file migration is notoriously brittle -- and we do NOT
-    // want to send invalid file references into the field system (it causes
-    // fatals), so return an empty item instead.

Let's preserve this comment.

ada hernandez’s picture

ada hernandez commented
Status: Needs work » Needs review
StatusFileSize
new remove_obsolete-2824444-5.patch1.25 KB

done!

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • catch committed 2542cdb on 8.3.x 
    Issue #2824444 by Adita, mikeryan: Remove obsolete try/catch from...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

  • catch committed b1f65ae on 8.2.x 
    Issue #2824444 by Adita, mikeryan: Remove obsolete try/catch from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.