URL language detection has missing title and description [#2824086]

Problem/Motivation

URL language detection is by default not available via the interface. Once enabled via configuration PHP Notices are shown and the language detection title and description are incomplete.

URL language detection error message
URL language detection title and description

To reproduce:
- Enable Language module
- Export configuration
- Edit the file 'language.types.yml' and edit. Add 'language_url' to the 'configurable' section as below.

configurable:
  - language_interface
  - language_content
  - language_url

- Re-import the configuration
- Go to /admin/config/regional/language/detection
- Notice the Message area and the section "language detection" near the bottom of the page.

Proposed resolution

Add title and description for the URL language detection.

Remaining tasks

t.b.d.

User interface changes

Completed title and description for URL language detection.

Comment	File	Size	Author
#17	2824086-17-language-url-detection.patch	2.26 KB	analiam319@gmail.com
#17	9.1.x: PHP 7.3 & MySQL 5.7 28,040 pass PHP 8.1 & MySQL 5.7 CI aborted
#9	language-url-detection-2824086-9.patch	685 bytes	manuel.adan
#9	8.5.x: PHP 7 & MySQL 5.5 23,478 pass, 1 fail
#2	language-url-detection-2824086-2.patch	690 bytes	Sutharsan
#2	8.2.x: PHP 5.5 & MySQL 5.5 20,924 pass, 1 fail
#2	language-url-detection-title-2824086.png	171.18 KB	Sutharsan
#2	language-url-detection-message-2824086.png	44.54 KB	Sutharsan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 November 2016 at 18:55

Sutharsan created an issue. See original summary.

Comment #2

Sutharsan CreditAttribution: Sutharsan commented 1 November 2016 at 18:58

Issue summary:	View changes
Status:	Active	» Needs review

File	Size
language-url-detection-message-2824086.png	44.54 KB
language-url-detection-title-2824086.png	171.18 KB
language-url-detection-2824086-2.patch	690 bytes
8.2.x: PHP 5.5 & MySQL 5.5 20,924 pass, 1 fail

Comment #3

Sutharsan CreditAttribution: Sutharsan commented 1 November 2016 at 19:19

Issue summary:

View changes

Comment #4

1 November 2016 at 19:37

Status:

Needs review

» Needs work

The last submitted patch, 2: language-url-detection-2824086-2.patch, failed testing.

Comment #5

markhuot CreditAttribution: markhuot as a volunteer commented 30 November 2016 at 16:57

Is there any desire to get this merged in? I'm happy to write tests or adjust config if there's a desire.

From my point of view there this is vital to using language negotiators. I have a custom language negotiator that is working well for the Admin node/edit and node/translate views but breaks when trying to view node/123 because my custom negotiator isn't called.

Comment #6

30 November 2016 at 16:57

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #7

30 November 2016 at 16:57

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #8

30 November 2016 at 16:57

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #9

manuel.adan

🌌

CreditAttribution: manuel.adan at Arcovía Digital for Asociación TecnoAriadna commented 22 June 2018 at 15:49

Version:	8.5.x-dev	» 8.6.x-dev
Status:	Needs work	» Needs review

File	Size
language-url-detection-2824086-9.patch	685 bytes
8.5.x: PHP 7 & MySQL 5.5 23,478 pass, 1 fail

Patch #2 did not apply in 8.5/8.6.x, ported (interdiff 2-9 fails).

Comment #10

22 June 2018 at 16:46

Status:

Needs review

» Needs work

The last submitted patch, 9: language-url-detection-2824086-9.patch, failed testing. View results

Comment #11

22 June 2018 at 16:46

Version:

8.6.x-dev

» 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #12

22 June 2018 at 16:46

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #13

22 June 2018 at 16:46

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #14

22 June 2018 at 16:46

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #15

22 June 2018 at 16:46

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #16

22 June 2018 at 16:46

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #17

analiam319@gmail.com CreditAttribution: analiam319@gmail.com commented 9 July 2021 at 19:56

Status:

Needs work

» Needs review

File	Size
2824086-17-language-url-detection.patch	2.26 KB
9.1.x: PHP 7.3 & MySQL 5.7 28,040 pass PHP 8.1 & MySQL 5.7 CI aborted

Re-made patch #9 for the latest 9.1.x (9.1.10 at the moment). I also added array access checks within the NegotationConfigureForm::configureForm where the reported errors were occurring.

Comment #18

9 July 2021 at 19:56

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #19

9 July 2021 at 19:56

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #20

9 July 2021 at 19:56

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #21

smustgrave CreditAttribution: smustgrave at Mobomo commented 6 February 2023 at 22:50

Status:	Needs review	» Needs work
Issue tags:		+Needs Review Queue Initiative, +Needs tests, +Needs accessibility review

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

This could use a test case to show the issue
Also tagging for accessibility review to make sure we are going down the right path.

Comment #22

6 February 2023 at 22:50

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.