Closed (fixed)
Project:
GatherContent
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2016 at 17:35 UTC
Updated:
18 Jan 2017 at 11:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mirom commentedHi aaronbauman, we are happy to review any patch from you.
Comment #3
aaronbaumanIn this patch:
- new function gc_gc_process_default_field() for handling GC fields (default case.)
- additional logic for date and datetime fields
Comment #4
aaronbaumanoops, left a debugging line.
Comment #5
mirom commentedHi, it seems that you left out translations.
Comment #6
aaronbaumanTranslation is identified and initialized first thing in the new helper function:
It's a different, more DRY approach than elsewhere in the module.
Comment #7
mirom commentedSorry, I didn't realise it. Looks fine for me, I will do some testing today.
Comment #9
mirom commented