Create a function like webform_component_parent_keys(), but which returns the names instead of form_keys.

CommentFileSizeAuthor
#5 webform-webform_component_parent_keys-2824070-5-D7.patch3.42 KBliam morland
#4 webform-webform_component_parent_keys-2824070-4-D7.patch1.45 KBliam morland
#2 webform-webform_component_parent_names-2824070-2-D7.patch1.35 KBliam morland

Comments

Liam Morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new webform-webform_component_parent_names-2824070-2-D7.patch1.35 KB
danchadwick’s picture

danchadwick commented
Status: Needs review » Needs work

You might make webform_component_parent_keys more general:

function webform_component_parent_keys($node, $component, $field_name = 'form_key') {

This would reduce code duplication and avoid creating a function which isn't actually used within webform itself.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Create webform_component_parent_names() » Improve webform_component_parent_keys()
Status: Needs work » Needs review
StatusFileSize
new webform-webform_component_parent_keys-2824070-4-D7.patch1.45 KB

Yes, good thinking. I've taken it one step further to allow requesting the entire component array.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new webform-webform_component_parent_keys-2824070-5-D7.patch3.42 KB

With tests.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Improve webform_component_parent_keys() » Allow webform_component_parent_keys() to return any property

  • Liam Morland committed fae0fad on 7.x-4.x 
    Issue #2824070: Allow webform_component_parent_keys() to return any...
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Fixed

  • Liam Morland committed fae0fad on 8.x-5.x 
    Issue #2824070: Allow webform_component_parent_keys() to return any...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.