Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland created an issue. See original summary.

Liam Morland’s picture

Status: Active » Needs review
FileSize
1.35 KB
DanChadwick’s picture

Status: Needs review » Needs work

You might make webform_component_parent_keys more general:

function webform_component_parent_keys($node, $component, $field_name = 'form_key') {

This would reduce code duplication and avoid creating a function which isn't actually used within webform itself.

Liam Morland’s picture

Title: Create webform_component_parent_names() » Improve webform_component_parent_keys()
Status: Needs work » Needs review
FileSize
1.45 KB

Yes, good thinking. I've taken it one step further to allow requesting the entire component array.

Liam Morland’s picture

Liam Morland’s picture

Title: Improve webform_component_parent_keys() » Allow webform_component_parent_keys() to return any property

  • Liam Morland committed fae0fad on 7.x-4.x
    Issue #2824070: Allow webform_component_parent_keys() to return any...
Liam Morland’s picture

Status: Needs review » Fixed

  • Liam Morland committed fae0fad on 8.x-5.x
    Issue #2824070: Allow webform_component_parent_keys() to return any...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.