On coverage analysis of core modules you do not need (and do not get a chance) to enter the version. The analysis runs ok, but because there is no version text, on the module page which shows the analysis summary there is no link to the actual report. On contrib module pages the version text is used as the link, so that is probably why it is not being shown for core modules.
If the link text was created from the module name and the version then this would always have a value even when no version text is present.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2823975-5.add_branch_for_core_link_to_report.patch | 924 bytes | jonathan1055 |
Comments
Comment #2
jonathan1055 commentedComment #3
legovaerI'm not 100% sure but I think this issue is related to #2823702: Machine name is displayed for core modules. As soon as we fix that one, this one will be fixed as well.
Basically what happens in the background for core modules:
So I assume that during the execution of step 2, we are not storing the correct title of the module.
Comment #4
jonathan1055 commentedThanks Levi. I've done a bit more investigation and actually it is not related to #2823702: Machine name is displayed for core modules. The link to the report is created only from the branch text, which works for contrib modules. However, the branch value is not currently stored for Core modules, so the link is null. If I manually edit a Core analysis node and enter some text in the branch field, and refresh the cache then a link is produced (and is correct).
I know that the way we link to the module and the report might be changing via #2824537: Re-design build overview but in the short term I will see if it is easy to store the branch value for Core analysis nodes too, so that at least we get a link. We will need the branch for Core modules anyway, to allow us to progress with #2823705: Drupal 8 Support
Comment #5
jonathan1055 commentedIt is a simple case of adding 'branch' to the Core form and saving it to the analysis node, just as with contrib modules. The layout of the analysis node display will change, I am sure, but storing the branch field for core is required anyway, and this automatically gives us the link to the report that was missing.
Comment #7
legovaerThanks for this Jonathan!
Comment #9
jonathan1055 commentedUnassigning myself from this closed issues.