Needs work
Project:
Paragraphs
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
31 Oct 2016 at 23:01 UTC
Updated:
12 Aug 2017 at 08:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ginovski commented1. Changed message, using host field name instead or single paragraph type
2. Fixed test.
Comment #3
ginovski commentedRerolled
Comment #4
toncic commentedVery nice patch.
Comment #5
drobnjak commentedComment #6
amenity commentedThis patch very much improves the content editor UX, thanks!
I had to manually apply the second hunk since it targets line 573 of ParagraphsAdministrationTest.php. In Paragraphs 8.x-1.0, that code has moved to line 572.
Comment #7
miro_dietikerThank you for the proposal and the review.
The question to me is - why do we need an empty message at all?
If you look at other Drupal fields, they don't have an empty text. They though typically have a default item added with the "Add more" button.
But i'm really not sure what will provide the best UX.
Comment #8
el1_1el commentedNot sure why this useful patch hasnt been committed, but I'm rerolling for 8.x.1.1 and for 8.x.1.x-dev. I also added the functionality to the experimental widget on both 1.1 and dev.
Comment #10
berdirPatch failed tests, that will need to be fixed.
Comment #11
el1_1el commentedYeah, given the volume of undefined vars for bundle in the unit tests, and the fact that when you select multiple paragraphs its ambiguous, Im gonna go with the suggestion in #7 and remove the empty text altogether.
Well, that was worse ¯\_(ツ)_/¯
Comment #12
el1_1el commentedone more try. var title was switched to field_title in dev. removing bundle check and just using the field label for the empty var.
Comment #13
el1_1el commentedmy mistake, title in one widget, field_title in the other
Comment #14
miro_dietikerDunno how much repetition for field name should be in the message now that inline form error is stable.
How is core handling this?
Comment #15
berdirIEF is still an optional module and core isn't changing it's validation messages because it. But that's not relevant anyway because this is not a validation message :)