Problem/Motivation

When a user opens the form located on /build and selects contrib from the select list, the default branch is set to 7x-1.x. If the user doesn't update this value, the tests will fail by default.

Proposed resolution

Replace the default value for branch to 7.x-1.x

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 edit_default_branch_in-2823707-1.patch696 bytesmgoncalves
#2 9 after first had finished could start next with 7.x.png156.27 KBjonathan1055
#2 4 after starting with wrong branch.png99.16 KBjonathan1055

Comments

legovaer created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new 4 after starting with wrong branch.png99.16 KB
new 9 after first had finished could start next with 7.x.png156.27 KB

Yes it does, this caught me out. The build still seemed to start but never completed (?maybe).

When I started it again with the correct branch the result in the overview replaced the bad unfinished one (which was good)

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented

It actually didn't replace it. If you take a look at that module's page, you can see that it states that the two builds completed successfully. I've created #2823754: Failed builds are shown as completed for this.

jonathan1055’s picture

jonathan1055 commented

OK. So does the module overview block just show 'running' and 'completed' builds? or just the latest for each module?

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented

That block just shows the latest for each module. If you want a history of the builds of a specific module, you will need to open the module's page. An improvement here can be creating a view that lists all of the modules which we analyze.

mgoncalves’s picture

mgoncalves commented
Assigned: Unassigned » mgoncalves
mgoncalves’s picture

mgoncalves commented
Assigned: mgoncalves » Unassigned
Status: Active » Needs review
StatusFileSize
new edit_default_branch_in-2823707-1.patch696 bytes

Review the patch, please.

  • legovaer committed 9a54290 on 8.x-1.x authored by mgoncalves 
    Issue #2823707 by mgoncalves, jonathan1055: Default branch in the build...
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs review » Fixed

Thanks!

jonathan1055’s picture

jonathan1055 commented

The test site has not been updated with this change yet. What is the plan for keeping it refreshed with the latest dev code, so that testers can verify the fixes?

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented

That's actually a good idea. I've just pushed the changes.

jonathan1055’s picture

jonathan1055 commented

Thanks. Yes I confirm that the default 7x typo has now been fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.