Problem/Motivation

In #2822297: Allow select Plain text / HTML message body display we've committed also a css role with !important.

It is to be avoided whenever possible as it limits code from easily extending / overriding it and thus a last resort of custom code.

And since this could be a cleanup followup, let's improve the js by adding the missing "second docblock" explaining what the tabs part is doing.

Proposed resolution

- Remove the !important property from the message.css

+++ b/css/message.css
@@ -52,6 +52,20 @@
+.inmail-message__body .ui-tabs-nav {
+  padding: .2em .2em 0 !important;
+}

- add doc for inmail.js tab part

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 remove_important-2822902-3.patch1016 bytesjohnchque

Comments

tduong created an issue. See original summary.

johnchque’s picture

Assigned: Unassigned » johnchque

I will fix this since I introduced this problem. :)

johnchque’s picture

Status: Active » Needs review
StatusFileSize
new1016 bytes

Might be a small patch, but it has potential. :)

miro_dietiker’s picture

Status: Needs review » Fixed

Committed. Not only potential, it's a winner! ;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.