There seems to be a new issue with views content panes argument handling introduced in version 1.11.

After updating we noticed that a glossary view using ajax was ignoring the argument and always returning the default

To reproduce the issue;

Launch simplytest.me with:

  • ctools
  • panels
  • views

eg here: https://goo.gl/gKQqI2

Enable the following modules:

  • views content panes
  • devel
  • devel generate
  • panels
  • mini panels
  • views
  • views ui

Use devel generate to create a number of basic page nodes.

Import this view:
http://pastebin.com/dhavxysA

Import this mini panel
http://pastebin.com/YDWgHF14

Edit the mini panel, go to the content tab and click live preview, clicking the glossary links in the attachment does not update the main content area.

CommentFileSizeAuthor
#3 views_content_existing_args-2822472-11750897.patch1 KBsomatick

Comments

somatick created an issue. See original summary.

somatick’s picture

somatick commented

I am attaching a suggested fix, which is simply that if the pane has no specific argument option set, (ie 'none') and there are existing arguments in the view (such as when set via views_ajax), to use the existing arguments instead of a NULL argument,

somatick’s picture

somatick commented
StatusFileSize
new views_content_existing_args-2822472-11750897.patch1 KB
somatick’s picture

somatick commented
Status: Active » Needs review
somatick’s picture

somatick commented
Issue summary: View changes
rivimey’s picture

rivimey
she/her
commented
Issue tags: +Regression
dieuwe’s picture

dieuwe
Location Auckland, NZ
commented
Status: Needs review » Reviewed & tested by the community

Thanks, this patch works great.

thalemn’s picture

thalemn commented

Thanks, I can confirm that the patch works on CTools 1.11.

Is this something that will be added to new releases? I don't think it's in 1.12.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Postponed
Parent issue: » #2180775: Allow views argument from context to make use of context arguments

It looks like you're using the dev branch that included #2180775: Allow views argument from context to make use of context arguments -- this had the code that caused this regression and has been reverted.

japerry’s picture

japerry
Location KOMK
commented
Status: Postponed » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.