Problem/Motivation

When a user accesses the /check page and the build status of one of the builds has changed, we see a text saying;

Build status changed to %build_status%

It seems like we're passing a wrong variable to the translate function.

screenshot

Steps to reproduce

  1. Via /build start a new analysis
  2. Wait for the analysis to be completed in TravisCI
  3. Open the /check page
  4. You will see a table containing the wrong translation

Proposed resolution

Debug and find out why Drupal isn't printing this variable.

CommentFileSizeAuthor
#4 2822193-4.patch686 byteshardikpandya
Screen Shot 2016-10-26 at 09.38.28.png67.71 KBlegovaer

Comments

legovaer created an issue. See original summary.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Issue tags: +Novice
hardikpandya’s picture

hardikpandya commented
Assigned: Unassigned » hardikpandya
hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Active » Needs review
StatusFileSize
new 2822193-4.patch686 bytes

Added patch.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs review » Fixed

Thanks

  • legovaer committed 0c827db on 8.x-1.x authored by hardik.p 
    Issue #2822193 by hardik.p, legovaer: Build status updates not displayed
jonathan1055’s picture

jonathan1055 commented
Title: Build status updates not displayed » Build status update text not displayed
Issue summary: View changes
Status: Fixed » Needs work

Good work hardik.p - now at least we have the parameter showing. However, I think this table is not that useful yet, as the build status shows as a digit. What does '1' actually mean? It would be helpful if the number could be converted to a text description of the status. Also this table should really have a date & time associated with it, otherwise what is the point of showing the information?

Please excuse me reverting the 'fixed' status to 'needs work', but I thought in this case it was better than starting a new issue.

jonathan1055’s picture

jonathan1055 commented
Status: Needs work » Fixed

Setting this back to 'fixed' because the page will be disappearing when #2821087: Use cron to check for build udpates is done.

jonathan1055’s picture

jonathan1055 commented
Title: Build status update text not displayed » Build status update parameter not displayed
Related issues: +#2821087: Use cron to check for build udpates

Forgot to add as related issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.