Problem

Though very light out of the box. commerce_cart_empty_page may be replaced by a view or something else maybe more expensive to render. Currently it's pre-rendered even when the output isn't needed.

Proposed Solution

Avoid rendering this theme function early.

CommentFileSizeAuthor
#3 2822130-2.patch1.69 KBjoelpittet
#2 2822130-1.patch1.82 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Issue tags: +Performance
FileSize
2822130-1.patch1.82 KB
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Active » Needs review
FileSize
2822130-2.patch1.69 KB

Whoops possible missing $content in the last patch.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Related issues: +#2372223: Create function commerce_cart_is_cart_empty()
rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro commented
Category: Bug report » Task
Status: Needs review » Fixed

Committed, thanks!

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.