When using the Database storage with limit the items above the limit gets truncated across contexts. The remove function needs to take contexts into consideration before removing the items.

CommentFileSizeAuthor
#5 entity_collection_storage_limit_context-2821933-5.patch1.79 KBsvenryen
#2 entity_collection_storage_limit_context-2821933-2.patch1.1 KBesolitos

Comments

mnlund created an issue. See original summary.

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Priority: Critical » Major
Status: Active » Needs review
StatusFileSize
new entity_collection_storage_limit_context-2821933-2.patch1.1 KB

Here's the patch that addresses this issue, context was not taken into consideration in the db_limit implementation.

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Status: Needs review » Reviewed & tested by the community
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Needs work

This patch has an issue in the line that says '+ $query->orderBy('depth', 'ASC')'

It should be $last_query , not $query . When applied, I get PHP error on that line, and the issue is resolved by changing the variable name to $last_query

svenryen’s picture

svenryen commented
Status: Needs work » Needs review
StatusFileSize
new entity_collection_storage_limit_context-2821933-5.patch1.79 KB

Here's an updated patch.

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Status: Needs review » Fixed

  • esolitos committed af73554 on 7.x-2.x authored by svenryen 
    Issue #2821933 by esolitos, svenryen, mnlund: DB Storage limit is not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.