The functional PromotionTest is currently missing a test that sets an end date. Plan is to make another test that is basically a clone of testCreatePromotion, but sets a date at the end.

This would keep the integrity of the first test making sure the end date isn't required.

CommentFileSizeAuthor
#3 functional_promotion_testCreatePromotionWithEndDate.patch2.32 KBmbreden
#2 functional_promotion_testCreatePromotionWithEndDate.patch2.32 KBmbreden
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mbreden created an issue. See original summary.

mbreden’s picture

mbreden CreditAttribution: mbreden at Acro Commerce commented
Status: Active » Needs review
FileSize
functional_promotion_testCreatePromotionWithEndDate.patch2.32 KB

Just copied the initial create test and added a bit to check the end-date box and set a date.

mbreden’s picture

mbreden CreditAttribution: mbreden at Acro Commerce commented
FileSize
functional_promotion_testCreatePromotionWithEndDate.patch2.32 KB

Woops, initial patch has wrong operator for end date. Updated.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Parent issue: » #2820908: OptionalDateWidget should not mark multiple_values support.

  • bojanz committed 9a67b8f on 8.x-2.x authored by mbreden 
    Issue #2821821 by mbreden: Create testCreatePromotionWithEndDate
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Somehow this one slipped through the cracks. Tweaked for latest -dev and committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.