If there's no color value for the mask-icon meta tag then there's no need to output it.

CommentFileSizeAuthor
#4 metatag-mask-icon-empty-color-2821713-test-only.patch1.48 KBWidgetsBurritos
#3 metatag-mask-icon-empty-color-2821713-3.patch2.2 KBWidgetsBurritos
#2 metatag-mask-icon-empty-color-2821713-2.patch973 bytesWidgetsBurritos

Comments

DamienMcKenna created an issue. See original summary.

WidgetsBurritos’s picture

WidgetsBurritos commented
Status: Active » Needs review
StatusFileSize
new metatag-mask-icon-empty-color-2821713-2.patch973 bytes

I have this same need myself. In researching this, it turns out the fix is a quick one-liner.

WidgetsBurritos’s picture

WidgetsBurritos commented
StatusFileSize
new metatag-mask-icon-empty-color-2821713-3.patch2.2 KB

The fix is one liner, but this probably deserves good test coverage as well, so a patch with updated tests.

WidgetsBurritos’s picture

WidgetsBurritos commented
StatusFileSize
new metatag-mask-icon-empty-color-2821713-test-only.patch1.48 KB

Just to confirm the tests was done properly, here is the test by itself, without the fix. This should fail.

WidgetsBurritos’s picture

WidgetsBurritos commented
bighappyface’s picture

bighappyface commented

+1 LGTM

I have tested it out with simplytest.me and the attribute is only visible when expected.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Category: Task » Bug report
Status: Needs review » Fixed
Parent issue: » #2844497: Plan for Metatag 7.x-1.21 release

Awesome fix, @WidgetsBurritos!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Fixed » Postponed

Lets port this to the 8.x-1.x branch after the favicons are ported.

WidgetsBurritos’s picture

WidgetsBurritos commented

Cool thanks!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Postponed » Patch (to be ported)

8.x-1.0 is out, so this is fair game again.