In #2817309: Metatag shows predefined global values every time in forms the entity field tests were restructured to make the reported bug more visible. Part of this plotted out more test methods for the entity field. Complete these new tests and add any more that might seem useful.

CommentFileSizeAuthor
#8 metatag-n2821476-7.interdiff.txt3.13 KBdamienmckenna
#7 metatag-n2821476-7.patch2.77 KBdamienmckenna
#4 metatag-n2821476-4.patch2.77 KBdamienmckenna
#2 metatag-n2821476-2.patch2.29 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2821476-2.patch2.29 KB

From Daniel Rose.

Status: Needs review » Needs work

The last submitted patch, 2: metatag-n2821476-2.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2821476-4.patch2.77 KB

This makes two changes - skip the test if there are no defaults allowed on this entity type, and add the field.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: metatag-n2821476-4.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2821476-7.patch2.77 KB

This should be a fixed patch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2821476-7.interdiff.txt3.13 KB

An interdiff comparing Daniel's original and the patch in #7.

DamienMcKenna credited Daniel_Rose.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks Daniel_Rose!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Needs work

Lets leave this open to add more tests.

dani3lr0se’s picture

dani3lr0se commented

Awesome! Glad I could help. :)