CommentFileSizeAuthor
#4 examples.main_test_conversion_2821422_04.patch4.69 KBrfay
#2 examples.main_test_conversion_2821422_02.patch4.9 KBrfay

Comments

rfay created an issue. See original summary.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
StatusFileSize
new examples.main_test_conversion_2821422_02.patch4.9 KB

Status: Needs review » Needs work

The last submitted patch, 2: examples.main_test_conversion_2821422_02.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new examples.main_test_conversion_2821422_04.patch4.69 KB
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Title: Convert Examples top-level tests to phpUnit Kernel tests » Convert Examples top-level tests to phpUnit Functional tests

  • rfay committed aac5969 on 8.x-1.x 
    Issue #2821422 by rfay: Convert Examples top-level tests to phpUnit...
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Sorry, I got completely blocked by this on another test conversion so went ahead and pushed it. Your feedback is welcome and I can do a followup patch.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

No worries... It looks good. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.