CommentFileSizeAuthor
#2 examples.page_example_test_conversion_2821418_02.patch4.56 KBrfay

Comments

rfay created an issue. See original summary.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
StatusFileSize
new examples.page_example_test_conversion_2821418_02.patch4.56 KB

  • Mile23 committed 9e70487 on 8.x-1.x authored by rfay 
    Issue #2821418 by rfay: Convert page_example tests to phpunit functional...
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Fixed 
  1. rename from page_example/src/Tests/PageExampleTest.php
rename to page_example/tests/Functional/PageExampleTest.php

    Needs to be in /tests/src/Functional/... 

  2. +++ b/page_example/tests/Functional/PageExampleTest.php
@@ -113,6 +113,7 @@ class PageExampleTest extends WebTestBase {
+    $assertExtras = $this->assertSession();

    Let's name it $assert_session.

    Also, I'm not sure whether we're supposed to keep those objects around, or just keep calling $this->assertSession(). I'll leave it as-is for now since it passes and there's no decent docs on the topic.

And... Since we're now in a PHPUnit-based environment, providerMenuLinks() can be a real @dataProvider. :-)

Fixed on commit. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.