After updating field_group to the latest DEV version, we stumpled upon an older bug, that should have been fixed in the https://www.drupal.org/node/2743127 issue.
But in firefox/ IE we still have the problem of missing labels.

In the latest DEV element.horizontal_tabs we set a weight for loading horizontal-tabs.js - this is a problem for firefox / IE browser. After removing this weight the js is loaded in the correct order.

I tested the behaviour in the following browsers:
- IE 10/11
- Firefox 46
- Chrome 53.0.2785
- Safari Version 10.0 (12602.1.50.0.10)

I'll attach a patch fixing this issue.

CommentFileSizeAuthor
#11 horizontal-tabs-titles-2820967-11.patch1.3 KBn3or
#6 horizontal-tabs-titles-2820967-6.patch641 bytesnils.destoop
#2 labels-horizontal-tabs-2820967-1.patch454 bytessteffenr

Comments

SteffenR created an issue. See original summary.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Status: Active » Needs review
StatusFileSize
new labels-horizontal-tabs-2820967-1.patch454 bytes

Attached you find a patch fixing the issue.

Please review.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Title: Labels of horizontal tabs won't show up in firefox » Labels of horizontal tabs won't show up in firefox/ IE
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Title: Labels of horizontal tabs won't show up in firefox/ IE » Labels of horizontal tabs won't show up in Firefox/ IE
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Assigned: steffenr » Unassigned
nils.destoop’s picture

nils.destoop commented
StatusFileSize
new horizontal-tabs-titles-2820967-6.patch641 bytes

Apparently my version of firefox has now Modernizr.details support since latest version. That's why i didn't notice it was broken again.
Can you test with patch in attachment? Your patch reverts a fix that was needed for 'required fields's support.

webcultist’s picture

webcultist commented

The patches don't work for me. Nether the first nor the second. I see the labels in firefox but in IE 9 - Edge they are invisible.

  • zuuperman committed 0f28942 on 8.x-1.x 
    Issue #2820967 by SteffenR, zuuperman: Labels of horizontal tabs won't...
nils.destoop’s picture

nils.destoop commented

I committed the patch, as it fixes firefox. Extra investigation will need to be done for Edge. I'll need a virtal box for this.

webcultist’s picture

webcultist commented

Would be great there is a solution for IE.
If you are really interested in the in a Vbox, you can get it here: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

n3or’s picture

n3or commented
StatusFileSize
new horizontal-tabs-titles-2820967-11.patch1.3 KB

I fixed the issue in IE11 (Windows 7) and IEEdge (Windows 10) by changing the summary source selection from feature detection to element detection.

In my tests the Modernizr.details was false, but the HTML was interpreted correctly.

Please check the attached patch.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs review » Reviewed & tested by the community

The patch in #11 looks good to me.

@zuuperman Instead of relying on a css class that could be removed in the future, I suggest to rely on jQuery.once's findOnce() function that seems more durable.
The code should be:

+        // If collapse.js did not do his work yet, call it directly.
+        if ($($details[0]).findOnce('collapse').length == 0) {
+          Drupal.behaviors.collapse.attach(context);
+        }
webcultist’s picture

webcultist commented

#11 works here...

  • zuuperman committed 98ac2ef on 8.x-1.x authored by n3or 
    Issue #2820967 by SteffenR, zuuperman, n3or: Labels of horizontal tabs...
nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Thx for the patch and testing it in IE. I committed it to dev

webcultist’s picture

webcultist commented

Thx @ n3or & zuuperman

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.