Submitting a value for Templates (admin/config/media/easychart/templates) other than the default (ie. any JSON) breaks config-export/import.

The error occurs either on a cim, or subsequent cex command:

Drupal\Core\Config\UnsupportedDataTypeConfigException: Invalid data type in config easychart.settings, found    [error]
in file/home/vagrant/docroot/web/profiles/mysite_profile/config/sync/easychart.settings.yml : Malformed
inline YAML string ("[{\r\n \"id\": --snip, really long line of json

Using Drupal's Json::encode to store the config string will correct this issue. I think this probably affects Presets as well, but I dont have anything in that setting and this is all I've had time to look into.

CommentFileSizeAuthor
#5 json-config-breaks-config-export-2820545-5.patch2.13 KBjuanl
#4 json-config-breaks-config-export-2820545-4.patch2.06 KBpetermallett
#2 json-config-breaks-config-export-2820545-2.patch2.3 KBpetermallett

Comments

petermallett created an issue. See original summary.

petermallett’s picture

petermallett commented
StatusFileSize
new json-config-breaks-config-export-2820545-2.patch2.3 KB

This patch adds form validation to test the JSON submitted and encodes the text using Json::encode before storing the string value into the config system.

This necessitated a json_decode with JSON_PRETTY_PRINT be used with the form default or it was just one long line.

thomas_rz’s picture

thomas_rz commented
Assigned: Unassigned » jyve
petermallett’s picture

petermallett commented
StatusFileSize
new json-config-breaks-config-export-2820545-4.patch2.06 KB

I was trying to make some adjustments to this today and ended up making a simpler patch by factoring out the Json object since this string is never meant to be used as HTML.

juanl’s picture

juanl commented
StatusFileSize
new json-config-breaks-config-export-2820545-5.patch2.13 KB

patch #2 updated for version 3.5.0

  • Web-Beest committed 13e6024 on 4.x authored by juanl 
    Issue #2820545 by petermallett, juanl: JSON configuration breaks config-...
web-beest’s picture

web-beest
he/him
Primary language Dutch
commented
Version: 8.x-3.x-dev » 4.0.0
Assigned: jyve » web-beest
Status: Needs work » Reviewed & tested by the community
web-beest’s picture

web-beest
he/him
Primary language Dutch
commented
Version: 4.0.0 » 4.0.1
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.