CommentFileSizeAuthor
#3 interdiff.txt1.74 KBamit.drupal
#3 t_2819956_3.patch16.2 KBamit.drupal
#2 t_2819956_1.patch15.3 KBnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new t_2819956_1.patch15.3 KB
amit.drupal’s picture

amit.drupal commented
StatusFileSize
new t_2819956_3.patch16.2 KB
new interdiff.txt1.74 KB

Use class - use Drupal\Core\StringTranslation\StringTranslationTrait; and submit new patch
I hope this is helpfull.

amit.drupal’s picture

amit.drupal commented
Status: Active » Needs review
nehakhadke’s picture

nehakhadke commented
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Reviewed & tested by the community

@amit.drupal There is not need to add use statement because it is present in the ContextAwarePluginBase (already extended from parent class BlockBase).

So, @nehakhadke your patch is OK.

Thank you.

gaurav.kapoor’s picture

gaurav.kapoor commented

The patch didn't apply anymore because of recent changes, so I rerolled it with the latest release. Also, removed some of other deprecated functions.

  • gaurav.kapoor committed 8c7b054 on 8.x-1.x 
    Issue #2819956 by amit.drupal, nehakhadke, gaurav.kapoor: $this->t()...
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.