Patch testing was turned on, probably on October 9th. Scald Dailymotion doesn't have tests per se yet though, so the dispatcher is marking everything as failing ( https://www.drupal.org/node/2487313/qa )

I guess automatic testing could be turned off again, but it'd probably be better to add some basic tests to the module to bootstrap the testing effort. I think part of the functionnality is tricky to test because it's going to rely on Dailymotion provided data, but would also make it easy to know when Dailymotion API changes, which is probably a good thing.

Comments

DeFr created an issue. See original summary.

DeFr’s picture

Status: Active » Needs review
StatusFileSize
new2.03 KB

Probably could start with something like this. Video used is Dailymotion sample for its own API documentation, so hopefully it should be stable.

Status: Needs review » Needs work

The last submitted patch, 2: 2819761-2-add-skeletton-tests.patch, failed testing.

The last submitted patch, 2: 2819761-2-add-skeletton-tests.patch, failed testing.

The last submitted patch, 2: 2819761-2-add-skeletton-tests.patch, failed testing.

The last submitted patch, 2: 2819761-2-add-skeletton-tests.patch, failed testing.

The last submitted patch, 2: 2819761-2-add-skeletton-tests.patch, failed testing.

DeFr’s picture

Status: Needs work » Needs review
StatusFileSize
new0 bytes

Let's require the module file.

DeFr’s picture

StatusFileSize
new1.79 KB

Empty file above.

The last submitted patch, 8: 2819761-8-add-skeletton-tests.patch, failed testing.

The last submitted patch, 8: 2819761-8-add-skeletton-tests.patch, failed testing.

The last submitted patch, 8: 2819761-8-add-skeletton-tests.patch, failed testing.

The last submitted patch, 8: 2819761-8-add-skeletton-tests.patch, failed testing.

The last submitted patch, 8: 2819761-8-add-skeletton-tests.patch, failed testing.

nagy.balint’s picture

Status: Needs review » Fixed

Thanks! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.