API page: https://api.drupal.org/api/drupal/core%21modules%21system%21templates%21...

says that links variable needs to be:

title: The link text.
href: The link URL. If omitted, the 'title' is shown as a plain text item in the links list. If 'href' is supplied, the entire link is passed to l() as its $options parameter.
attributes: (optional) HTML attributes for the anchor, or for the tag if no 'href' is supplied.

but the href element is wrong. In template_preprocess_links url is used.

CommentFileSizeAuthor
#4 use_url_not_href-2818375-4.patch1 KBhardikpandya

Comments

lussoluca created an issue. See original summary.

idebr’s picture

idebr commented
Issue tags: +Novice
hardikpandya’s picture

hardikpandya commented
Assigned: Unassigned » hardikpandya
hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Active » Needs review
StatusFileSize
new use_url_not_href-2818375-4.patch1 KB

Patch attached.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
commented
Status: Needs review » Reviewed & tested by the community

+1 for me

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: use_url_not_href-2818375-4.patch, failed testing.

criz’s picture

criz
he/him
Location Vienna/Austria
commented
Status: Needs work » Reviewed & tested by the community

Rescheduled test worked. Patch looks good.

  • catch committed 380e652 on 8.3.x 
    Issue #2818375 by hardik.p, lussoluca: links.html.twig uses url not href

  • catch committed 54d9de6 on 8.2.x 
    Issue #2818375 by hardik.p, lussoluca: links.html.twig uses url not href...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.