CommentFileSizeAuthor
#6 coffee-coffee_breaks_page_with_rtl-2815381-6.patch546 bytesmqanneh
coffe-rtl-1356930.patch410 bytesahmadhalah
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ahmadhalah created an issue. See original summary.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Related issues: +#2407835: Coffee breaks whole page when using right to left (rtl) languages

@ahmadhalah please can you expand the IS and explain what problem you notice (possible with print screens :)) and which version of drupal core and coffee are you using?
I have tested RTL languages with drupal 8.2.x + coffee dev using bartik, seven and adminimal theme without issues.
Thanks!

michaelmol’s picture

michaelmol CreditAttribution: michaelmol commented
Status: Active » Postponed (maintainer needs more info)
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
CreditAttribution: mqanneh as a volunteer and at Vardot commented

Duplicate with issue #2407835: Coffee breaks whole page when using right to left (rtl) languages

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
CreditAttribution: mqanneh as a volunteer and at Vardot commented

@michaelmol the same issue was with D7 of this module - #2407835: Coffee breaks whole page when using right to left (rtl) languages
with RTL pages it will make the page have a horizontal scrollbar because of this style

.coffee-form-wrapper.hide-form {
  position: absolute;
  left: -100%;
  opacity: 0;
}

D7 fix was to change it from left: -100%; to top: -100%;

.coffee-form-wrapper.hide-form {
  position: absolute;
  top: -100%;
  opacity: 0;
}
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
CreditAttribution: mqanneh as a volunteer and at Vardot commented
Assigned: ahmadhalah » Unassigned
Status: Postponed (maintainer needs more info) » Needs review
FileSize
coffee-coffee_breaks_page_with_rtl-2815381-6.patch546 bytes
willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Needs review » Postponed (maintainer needs more info)

please can you expand the IS and explain what problem you notice (possible with print screens :)) and which version of drupal core and coffee are you using?
I have tested RTL languages with drupal 8.2.x + coffee dev using bartik, seven and adminimal theme without issues.

@mqanneh please can you add the required info? Thanks

  • mqanneh authored 5e4524b on 8.x-1.x 
    Issue #2815381 by mqanneh, ahmadhalah, michaelmol: Coffee breaks whole...
michaelmol’s picture

michaelmol CreditAttribution: michaelmol commented
Status: Postponed (maintainer needs more info) » Fixed

We have the same solution in 7.x version, so I have commited these line of css.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Good :)
Testing ...
Waiting for the next Release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
CreditAttribution: joegraduate at The University of Arizona commented
Parent issue: » #3111053: Plan for Coffee 8.x-1.0 stable release