Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.// Delete responses have an empty body.
return new ModifiedResourceResponse(NULL, 204);| Comment | File | Size | Author |
|---|---|---|---|
| #26 | fix_issue-2815063-26.patch | 743 bytes | leeotzu |
| #22 | fix_issue-2815063-22.patch | 743 bytes | leeotzu |
| #19 | fix_issue-2815063-19.patch | 745 bytes | yogeshmpawar |
| #17 | fix-issue-2815063-17.patch | 739 bytes | shruti1803 |
| #14 | fix-issue-2815063-14.patch | 739 bytes | lomasr |
Comments
Comment #2
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded the patch with fix.
Kindly review.
Thanks!
Comment #3
Chi CreditAttribution: Chi commentedWell, I just realized that this might not be a typo though it sounds strange. "Delete" stands for HTTP method name in this context. I would like someone with more English experience to review this.
Comment #4
Wim LeersYep, this makes sense. Thanks!
Comment #5
Chi CreditAttribution: Chi commentedI would like to emphasize that we are not deleting anything in that line. :)
Comment #6
alexpottCommitted and pushed 5233c3d to 8.3.x and 7a2da64 to 8.2.x. Thanks!
Comment #9
Chi CreditAttribution: Chi commentedStill thinking the spelling is wrong. Delete is not a verb here. It is kind of adjective describing the response method (GET, POST, OPTIONS, etc). We are not deleting responses here but only noting why this response has an empty body. I propose using uppercase for the method name like follows: "DELETE responses have an empty body."
Let me know if I am mistaken.
Comment #10
Wim LeersUgh, you're totally right. I don't know how I missed that :(
It should just have been
s/Delete/DELETE/Comment #11
alexpottLet's just open an new issue for that. The bit that was changed was not the delete part. Reverting is totally OTT for this.
Comment #12
Wim LeersEhm, no, the original sentence made sense. The new sense makes no sense at all. Again, my bad :(
"DELETE responses" have an empty body -> makes sense!
"Delete responses which have an empty body" -> makes no sense, because this code is not deleting any responses.
Comment #14
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedI agree with Wim. "DELETE responses" have an empty body is a better idea . Added a patch.
Comment #15
shruti1803 CreditAttribution: shruti1803 at Iksula commentedComment #17
shruti1803 CreditAttribution: shruti1803 at Iksula commentedComment #19
yogeshmpawarI have rerolled the patch against 8.3.x because #17 failed to apply.
Comment #20
Chi CreditAttribution: Chi commentedI would not use quotes in this case for the purpose of consistency. We are usually not using them in this context. See EntityResource::delete method documentation as an example.
Comment #21
Chi CreditAttribution: Chi commentedComment #22
leeotzu CreditAttribution: leeotzu as a volunteer and at Srijan | A Material+ Company commentedChanges applied as per suggestion from @chi for 8.3.x
Comment #23
leeotzu CreditAttribution: leeotzu as a volunteer and at Srijan | A Material+ Company commentedComment #24
Chi CreditAttribution: Chi commentedThe method name can remain in upper case.
Comment #25
Grayside CreditAttribution: Grayside at Phase2 for Norwegian Cruise Line commentedAll caps for HTTP method names are standard practice in formal tech writing.
Comment #26
leeotzu CreditAttribution: leeotzu as a volunteer and at Srijan | A Material+ Company commentedUpdated the method name to uppercase.
Comment #27
Chi CreditAttribution: Chi commentedComment #30
catchCommitted/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!