This is really low priority, but the d6_field migration has some outdated configuration. The process pipeline for determining the field type first calls the field_type process plugin, then skip_on_empty. The field_type plugin extends StaticMap (and has for some time), which means it will skip the row by default if mapping fails. Therefore, having skip_on_empty in the process pipeline is unnecessary. The d7_field migration already knows this, so I think the two migrations should be consistent.

CommentFileSizeAuthor
#2 2814971-2.patch5.8 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Status: Active » Needs review
StatusFileSize
new5.8 KB
benjy’s picture

Status: Needs review » Reviewed & tested by the community

Makes sense now that the skip row exception is thrown in the field type plugin.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 54a38cd to 8.3.x and 3a56b0d to 8.2.x. Thanks!

  • alexpott committed 54a38cd on 8.3.x
    Issue #2814971 by phenaproxima: Remove redundant configuration in...

  • alexpott committed 3a56b0d on 8.2.x
    Issue #2814971 by phenaproxima: Remove redundant configuration in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.