Problem/Motivation

In order to improve the performance of the module we need to load TravisClient as a service.

Proposed resolution

Transform TravisClient to a service. Suggested here is that we use a factory in order to inject some default values into the HTTP client.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Transform TravisClient into a service Instructions
Replace all occurrences of TravisClient with the new service Novice Load the service via or a factory or a constructor
Add automated tests #2811497: Develop phpunit tests for Generator
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 travisclient_needs_to-2813379-3.patch6.95 KBlegovaer

Comments

legovaer created an issue. See original summary.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Issue summary: View changes
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Active » Needs review
StatusFileSize
new travisclient_needs_to-2813379-3.patch6.95 KB
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • legovaer committed df2ce81 on 8.x-1.x 
    Issue #2813379 by legovaer: TravisClient needs to become a service
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.