Problem/Motivation

When accessing the page which checks if some of the builds have been completed, the only thing the user sees is a "Hello world" message.

Proposed resolution

The page needs to display default help text which will help the user to understand the use of this page. In the background, Drupal needs to check if some of the yet existing builds have been completed.

If one of the builds have been completed, a message needs to be displayed saying: "X builds have been completed and the results are available now.". Also a watchdog entry needs to be added.

If Drupal is unable to access Travis, an error message needs to be displayed which is saying: "An error occured. Please try again later.". Also a watchdog needs to be added

Remaining tasks

Complete

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Clean up the controller class Add documentation & Drupal Coding Standards compliant Complete
Display help text on the check page Novice Use hook_help to add help details Complete
Check if the builds are completed Interact with Travis to check if any of the builds has been completed Complete
Display a message when builds are completed Novice See summary Complete
Display an error message when Drupal is unable to reach Travis Novice Via try and catch we should check if the operation was successful Complete
Create a patch Instructions
Reroll the patch if it no longer applies. Instructions
Update the issue summary Instructions
Update the issue summary noting if allowed during the rc Template
Add automated functional tests Instructions Will be done in #2811495: Develop functional tests for Controller Assigned to: legovaer
Improve patch documentation or standards (for just lines changed by the patch) Novice Instructions
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#18 interdiff-2813369-12-18.txt4.19 KBlegovaer
#18 clean_up_the_the-2813369-18.patch7.91 KBlegovaer
#17 interdiff-2813369-14-17.txt1.6 KBlegovaer
#17 clean_up_the_the-2813369-17.patch7.1 KBlegovaer
#14 interdiff-2813369-12-14.txt1.13 KBlegovaer
#14 clean_up_the_the-2813369-14.patch5.82 KBlegovaer
#12 clean_up_the_the-2813369-12.patch4.81 KBlegovaer
#10 clean_up_the_the-2813369-10.patch4.75 KBlegovaer
#8 interdiff-2813369-6-8.txt7.22 KBlegovaer
#8 clean_up_the_the-2813369-8.patch7.33 KBlegovaer
#6 clean_up_the_the-2813369-6.patch582 byteslegovaer
#4 edit_cean_up_the_the-2813369-4.patch6.04 KBlegovaer

Comments

legovaer created an issue. See original summary.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Title: Fix & clean up the the controller » Cean up the the controller
Issue summary: View changes
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Issue summary: View changes
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Issue summary: View changes
StatusFileSize
new edit_cean_up_the_the-2813369-4.patch6.04 KB
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Title: Cean up the the controller » Clean up the the controller
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new clean_up_the_the-2813369-6.patch582 bytes

Status: Needs review » Needs work

The last submitted patch, 6: clean_up_the_the-2813369-6.patch, failed testing.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_the_the-2813369-8.patch7.33 KB
new interdiff-2813369-6-8.txt7.22 KB
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work 
+++ b/src/DrupalCoverageCoreController.php
@@ -0,0 +1,103 @@
+    $generator = new Generator();

You need to provide a parameter in the Generator class (according to the latest 8.x-1.x branch). I did it like this in #2819347: Create permissions not sure if that is the correct way.

$generator = new Generator(\Drupal::service('drupal_coverage_core.travis_client'));

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_the_the-2813369-10.patch4.75 KB

Updated the patch as it was no longer valid. Also fixed #9.

Status: Needs review » Needs work

The last submitted patch, 10: clean_up_the_the-2813369-10.patch, failed testing.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_the_the-2813369-12.patch4.81 KB

Seems like there was a typo in my patch..

Status: Needs review » Needs work

The last submitted patch, 12: clean_up_the_the-2813369-12.patch, failed testing.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_the_the-2813369-14.patch5.82 KB
new interdiff-2813369-12-14.txt1.13 KB
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented 
  1. +++ b/tests/src/Functional/DrupalCoverageCoreTest.php
+++ b/tests/src/Functional/DrupalCoverageCoreTest.php
@@ -7,7 +7,7 @@ use Drupal\simpletest\WebTestBase;

    We're using SimpleTest now, but this has been deprecated and should be replaced with a functional PHPUnit test. 

  2. +++ b/tests/src/Functional/DrupalCoverageCoreTest.php
@@ -7,7 +7,7 @@ use Drupal\simpletest\WebTestBase;
+ * @group dcc_debug

    This needs to be drupal_coverage_core

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs review » Needs work
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_the_the-2813369-17.patch7.1 KB
new interdiff-2813369-14-17.txt1.6 KB
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
StatusFileSize
new clean_up_the_the-2813369-18.patch7.91 KB
new interdiff-2813369-12-18.txt4.19 KB
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good! Good to see simpletest is also removed :)

  • legovaer committed bee03b6 on 8.x-1.x 
    Issue #2813369 by legovaer: Clean up the the controller
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.