Problem/Motivation

We have JSON documents hardcoded as strings that are consumed by our tests.

Proposed resolution

Put them into files, which are easier to read and we get IDE support for syntax checks.

Remaining tasks

Add patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2813081-2.patch13.64 KBpenyaskito

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2813081-2.patch13.64 KB

Extracts JSON strings to files in tests/modules/lingotek_test/document_responses and simplified \Drupal\lingotek_test\LingotekFake::downloadDocument

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Tests green as expected.

  • penyaskito committed b4b73ae on 8.x-1.x 
    Issue #2813081 by penyaskito: Extract json documents used by tests in \...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed b4b73ae and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.