Remove drupal_set_message's from captcha install [#2811777]

Problem/Motivation

From discussion in comment #9 in issue #2808087: Improve captcha_install(), correctly create dynamic captcha points, move static captcha points to default config
The second drupal_set_message is broken (page cache is a module now, not a setting).
Other modules don't do this either, the modules page has links to settings and help built-in.

Proposed resolution

Possibly add a link to the settings instead

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#8	2811777-8-8.x-1.x-dev.patch	2.2 KB	amit.drupal
#8	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 32 pass
#6	interdiff-6.txt	1.29 KB	Prashant.c
#6	2811777-6-8.x-1.x-dev.patch	1.61 KB	Prashant.c
#6	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 32 pass
#2	changes_2811777.png	31.05 KB	lomasr
#2	2811777_2.patch	1.61 KB	lomasr
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 32 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

5 October 2016 at 14:24

Ginovski created an issue. See original summary.

Comment #2

lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 19 October 2016 at 10:07

File	Size
2811777_2.patch	1.61 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 32 pass
changes_2811777.png	31.05 KB

I agree with the proposed solution . Added a patch.

Comment #3

lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 19 October 2016 at 10:07

Status:

Active

» Needs review

Comment #4

ddrozdik CreditAttribution: ddrozdik as a volunteer commented 19 October 2016 at 12:13

I guess this is an important message, I suggest to make it bold, to take user attention on it.

Comment #5

ddrozdik CreditAttribution: ddrozdik as a volunteer commented 19 October 2016 at 12:14

Status:

Needs review

» Needs work

Comment #6

Prashant.c

he/him

English

Dharamshala

CreditAttribution: Prashant.c as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 21 October 2016 at 07:28

Status:

Needs work

» Needs review

File	Size
2811777-6-8.x-1.x-dev.patch	1.61 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 32 pass
interdiff-6.txt	1.29 KB

Re-submitting the patch by adding <b> tag to the returned output.

Comment #7

ddrozdik CreditAttribution: ddrozdik as a volunteer commented 21 October 2016 at 09:35

Status:

Needs review

» Reviewed & tested by the community

looks good.

Comment #8

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 25 October 2016 at 07:28

File	Size
2811777-8-8.x-1.x-dev.patch	2.2 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 32 pass

Re-submitting Patch #6 .

+++ b/captcha.module

+ return $output;
return render array rest looks good.

return ['#markup' => $output];

Comment #9

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented 26 November 2016 at 20:30

Comment #10

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented 26 November 2016 at 20:31

Status:

Reviewed & tested by the community

» Fixed

Comment #11

26 November 2016 at 20:31

wundo committed 6ded687 on 8.x-1.x authored by amit.drupal

Issue #2811777 by lomasr, Prashant.c, amit.drupal, ddrozdik, Ginovski,...

Comment #12

10 December 2016 at 20:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #13

jomik CreditAttribution: jomik commented 13 May 2017 at 07:46

Hi all,
when I trey to install CAPTCHA by drupal 8, I get this message:
Unable to install CAPTCHA, captcha.captcha_point.contact_message_feedback_form, captcha.captcha_point.contact_message_personal_form, captcha.captcha_point.user_login_form, captcha.captcha_point.user_pass, captcha.captcha_point.user_register_form, captcha.settings already exist in active configuration.
Can anybody help me?
Thanks in advance,
Joseph