Problem/Motivation

Action module has some forms in \Drupal\action\Form and some in \Drupal\action directly. Other modules do this where they have entity forms in the module namespace directly and other forms in the Form namespace (which is already confusing IMO). But action is worse because it has both mixed up in both places.

Proposed resolution

Move all Forms to the Form sub-namespace.

Remaining tasks

User interface changes

None.

API changes

No Api change b/c Forms classes are internals see https://www.drupal.org/core/d8-bc-policy#controllers

CommentFileSizeAuthor
#19 interdiff-2811749-13-19.txt3.26 KBnaveenvalecha
#19 2811749-19.patch9.81 KBnaveenvalecha
#13 2811749-13.patch9.81 KBandypost
#7 2811749-7.patch11.77 KBharsha012
#2 2811749-2.patch2.43 KBnaveenvalecha

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Active » Needs review
StatusFileSize
new 2811749-2.patch2.43 KB
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

chi’s picture

chi commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
harsha012’s picture

harsha012 commented
Status: Needs work » Needs review
StatusFileSize
new 2811749-7.patch11.77 KB

re-rolled the patch to 8.5

chi’s picture

chi commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

It works for me.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

They are internal, yes, but can we just deprecate the old ones and have them inherit from the new, rather than removing them? That way there's no disruption.

Thanks!

chi’s picture

chi commented

BTW, the same filter module has the same issue.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 2811749-13.patch9.81 KB

- Added CR https://www.drupal.org/node/3033540
- Addressed #9

Status: Needs review » Needs work

The last submitted patch, 13: 2811749-13.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

Bot flux

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Thanks Andy!

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs work

These will need to be 'Deprecated in 8.8' now, sorry folks

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2811749-19.patch9.81 KB
new interdiff-2811749-13-19.txt3.26 KB

Here's the updated patch. Moving back to RTBC as it just updated the deprecated message.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Crediting xjm

  • larowlan committed 7c845e1 on 8.8.x 
    Issue #2811749 by naveenvalecha, andypost, harsha012, xjm: Move...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed 7c845e1 and pushed to 8.8.x. Thanks!

Published the change record

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.