Was assessing using readme.md files and how it looked in advanced_help and encoutered the following errors:

 PHP Fatal error:  Call to undefined function Drupal\\advanced_help\\Controller\\libraries_load()

This identifies an undisclosed dependency on the libraries project when using markdown.

Once you download libraries with Drush you further get:

 PHP Fatal error:  Class 'Michelf\\MarkdownExtra' not found....

This identifies the undisclosed dependency on \Michelf\\MarkdownExtra.

Its unclear to me whether there is still a dependency on https://drupal.org/project/markdown to view .md files but it seems less than ideal that we would hard crash when someone clicks on the readme links when the proper libraries are not installed. The markdown extra library is available via composer so technically we may be able to use a module specific composer.json to advertise the dependency instead, but then do we still need the libraries dependency?

I'm happy to submit a patch, but would like more direction from maintainers as to the desired solution.

Comments

metzlerd created an issue. See original summary.

gnuget’s picture

When that code was written there wasn't a stable release of the Markdown module. Two options:

  • Still rely on the Markdown module.
  • Load the lib using composer.

I would prefer the latter.

gnuget’s picture

A composer file was added at #2770351: Include composer.json so we can include the dependency there.

gnuget’s picture

Status: Active » Fixed

I added the dependency directly in the composer.json file.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.