People who review projects and receive credit on fixed issues are nonetheless not getting credit for it on their profiles nor, for affiliated organizations, in Marketplace rank. If such credit were shown gisle and klausi, for example, would have hundreds of credits for the Project Application project this year— or at least the dozens i've credited to them. Instead the Project Application project doesn't count towards anyone's issue credits, which certainly isn't helping the ongoing crisis of unreviewed or underreviewed applications. Clearly, klausi and gisle do the nearly-thankless (thanks!!!) work anyway, but credit should be given where credit is due, and it might provide others with a little extra motivation. (Companies! Application review is a great way to learn, and perhaps soon junior dev time directed there will also translate into marketplace rank.)

Comments

mlncn created an issue. See original summary.

drumm’s picture

Title: Include issue credits given to users in the Project Application review queue on profile pages and Marketplace rankings » Allow more maintainers to grant credit

Credit on issues can currently assigned by project maintainers with “Write to VCS” access only. All the maintainers of the Project Applications queue have “Maintain issues”.

I think it would be okay to broaden access to assign credit to everyone with “Maintain issues”. For core this would broaden the number of people saving credit from the 13 committers (some retired, like me) to about 80 people, I think corresponding to people who have been in MAINTAINERS.txt. I’d want a comment from a core committer before going ahead and doing this.

mlncn’s picture

Thank you! To confirm:

drumm’s picture

I’d like to avoid special behavior per-project, which is why I wanted to check on the impact on core before going ahead and changing the behavior.

It's possible to see and use the option to give credit, and for it not to work? (And this is expected?)

Yes, the UI shows for all logged-in users since it doubles as the commit message/command generator. Maintainers who are able to save credit on Drupal.org see a couple UI additions, the “Giving credit to …” text at the top of the fieldset, and “As a project maintainer…” help at the bottom of the fieldset.

mlncn’s picture

OK, great!

After making this issue, i noticed that #2666584: [Community Initiative Proposal] Project Applications Process Revamp specifically calls for this in the summary and so has decided on this i think, so for the purpose of the Project Application review process specifically, we could simply give project maintainers VCS access even though they won't use it, it seems.

drumm’s picture

we could simply give project maintainers VCS access even though they won't use it

Yes, that would be a quick way to solve this for project applications.