Due to commit of #2769721: Add Maintainers to composer.json now composer.json coming with incorrect syntax, so the require part not phase correctly therefore mkalkbrenner/php-htmldiff-advanced not installed, but it is not the only problem inside composer.json...

Here some cleanup and bugfix:

  • Regroup duplicated support section
  • Regroup duplicated require section, so now mkalkbrenner/php-htmldiff-advanced install correctly
  • Add the new "repositories" section with https://packages.drupal.org/8
  • Remap "drupal/entity": "8.*" to newly "drupal/entity": "~1.0" format
  • Overall syntax cleanup with %!python -m json.tool inside vim
CommentFileSizeAuthor
#13 diff-fix_composer_json-2810301-13.patch686 byteshswong3i
#8 interdiff-2810301-5-6.txt507 byteshswong3i
#6 diff-fix_composer_json-2810301-6.patch1.83 KBhswong3i
#5 interdiff-2810301-2-5.txt2.63 KBdrobnjak
#5 diff-fix_composer_json-2810301-5.patch1.84 KBdrobnjak
#2 diff-fix_composer_json-2810301-2.patch2.64 KBhswong3i

Comments

hswong3i created an issue. See original summary.

hswong3i’s picture

hswong3i commented
Issue summary: View changes
StatusFileSize
new diff-fix_composer_json-2810301-2.patch2.64 KB
hswong3i’s picture

hswong3i commented
Status: Needs work » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

You are switching to a 4 spaces indentation.
Before we had 2 spaces and that's our default. We should stick to that.

drobnjak’s picture

drobnjak commented
Assigned: Unassigned » drobnjak
Status: Needs work » Needs review
StatusFileSize
new diff-fix_composer_json-2810301-5.patch1.84 KB
new interdiff-2810301-2-5.txt2.63 KB

Fixed indentation.

hswong3i’s picture

hswong3i commented
StatusFileSize
new diff-fix_composer_json-2810301-6.patch1.83 KB

Syntax and indent check once again

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented

Please @hswong3i provide an interdiff when making changes over another patch.

hswong3i’s picture

hswong3i commented
StatusFileSize
new interdiff-2810301-5-6.txt507 bytes
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed a minimalistic fix.
Removed the double require line.

Anyway, we test-depend to entity in diff.info, but i can't remember why. I never enabled it when testing, also its version number was wrong in composer.json, so i simply dropped the line.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed a minimalistic version, removed the entity dependency as we only have it in test dependencies and i was unable to identify its need. See #2812839: Remove entity module from tests

hswong3i’s picture

hswong3i commented
Status: Fixed » Needs work

@miro_dietiker sorry that at least from correct JSON syntax point of view the support section is still duplicated :-(

hswong3i’s picture

hswong3i commented
StatusFileSize
new diff-fix_composer_json-2810301-13.patch686 bytes

Remove duplicated support section.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Reviewed & tested by the community

yes, this removes the duplicated.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

OK fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.