Closed (fixed)
Project:
Drupal core
Version:
8.7.x-dev
Component:
user.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Sep 2016 at 16:37 UTC
Updated:
26 Sep 2018 at 14:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
michielnugter commentedComment #6
tessa bakkerComment #7
tessa bakkerPatch with:
- conversion of the AJAX part to Webdriver test
- other tests to Browser test (with some speed improvement, by using the testing profile)
Comment #8
tessa bakkerComment #9
lendudeThis looks great, just some minor clean up as far as I can see:
So nice that the browser test doesn't need this anymore!
Still weird that this is needed, but I saw it fail otherwise....so lets keep it
This can just be {@inheritdoc} in the new test.
Do we need the block in the javascript test? Don't think so, right? And the page caching?
Comment #11
lendudeAddressed my own feedback
#9.2 works on my machine when I take it out, lets see what the Bot thinks
Comment #12
borisson_The Bot, it agrees! As do I, this looks very solid and #11 resolves #9.
Comment #13
alexpottCommitted and pushed e4146aa44f to 8.7.x and 7a3a01f34f to 8.6.x. Thanks!
Comment #16
lendudeWhoops, this actually forgot to move the new tests to the right spot and failed to set the right namespace!
Comment #17
navneet0693 commentedComment #19
alexpottUnfortunately the patch does not apply.
Comment #20
lendudeRerolled for 8.7.x
Comment #21
borisson_The patch applies again.
Comment #22
alexpottCommitted and pushed 57dfd4ba8c to 8.7.x and a42db5a7ee to 8.6.x. Thanks!