Convert AJAX part of \Drupal\system\Tests\Ajax\FrameworkTest to JavascriptTestBase

First roll.

I've stripped a bit of stuff that has to do with command ordering, especially in the Javascript test, since this is covered by \Drupal\Tests\Core\Ajax\AjaxResponseTest.

I've added some methods from WebTestBase to the BrowserTestBase test since these methods returns the Ajax commands and those are what are under test here. So in this particular case it actually makes sense to have those commands.

testLazyLoadOverriddenCSS doesn't work yet because it seems this statement:

// The test theme overrides js.module.css without an implementation,
// thereby removing it.

is incorrect, the file under test isn't removed at all currently. Haven't figured out why yet, so that will fail.

Ok, so that test should just pass. Opened #3006625: 'stylesheets-remove' test is broken to figure out if the functionality is broken or the test setup is wrong.

this passes with the patch in #3006625: 'stylesheets-remove' test is broken so this needs to wait for that to land.

cleaned up a bit.

#3006625: 'stylesheets-remove' test is broken landed so this should be green now...

Great work!

1. +++ b/core/modules/system/tests/src/Functional/Ajax/FrameworkTest.php
   @@ -0,0 +1,158 @@
   +  public function testAJAXRender() {
   ...
   +  public function testOrder() {
   

   Let's convert these to WDTB as well just like #2809531-9: Convert AJAX part of \Drupal\system\Tests\Ajax\FormValuesTest::testSimpleAjaxFormValue to JavascriptTestBase and get rid of assertCommand and drupalGetAjax

2. +++ b/core/modules/system/tests/src/FunctionalJavascript/FrameworkTest.php
   @@ -0,0 +1,113 @@
   +    $this->getSession()->getPage()->checkField('add_files');
   +    $this->getSession()->getPage()->pressButton('Submit');
   +    $this->assertSession()->assertWaitOnAjaxRequest();
   ...
   +    $this->assertSession()->responseNotContains('js.module.css?', 'Ajax lazy loading does not add overridden CSS files.');
   

   Local vars please.

Thanks for the review!

#15.1 I feel they are needed in this case, since these tests are about testing the actual Commands and not about the results of these commands (as is usually the case, and which is what we test in a Javascript test). Updated the IS to reflect this. Make sense?
#15.2 fixed

I feel they are needed in this case, since these tests are about testing the actual Commands and not about the results of these commands

If that's the case then let's convert those to KTB/Unit test and only test the JS functionality in JS Test. If you think this is out of scope then feel free to RTBC. It is RTBC other than this.

+++ b/core/modules/system/tests/src/FunctionalJavascript/FrameworkTest.php
@@ -0,0 +1,122 @@
+    ¶

Can be fixed on commit.

I feel like that is out of scope. This one is good to go.

Committed and pushed f762c6a708 to 8.7.x and b1d24dd33c to 8.6.x. Thanks!

diff --git a/core/modules/system/tests/src/FunctionalJavascript/FrameworkTest.php b/core/modules/system/tests/src/FunctionalJavascript/FrameworkTest.php
index a63262b614..60f10b35f9 100644
--- a/core/modules/system/tests/src/FunctionalJavascript/FrameworkTest.php
+++ b/core/modules/system/tests/src/FunctionalJavascript/FrameworkTest.php
@@ -106,7 +106,7 @@ public function testLazyLoadOverriddenCSS() {
     $this->drupalGet('ajax_forms_test_lazy_load_form');
     $page = $this->getSession()->getPage();
     $assert = $this->assertSession();
-    
+
     $page->checkField('add_files');
     $page->pressButton('Submit');
     $assert->assertWaitOnAjaxRequest();

Fixed spaces on commit.

The 8.6.x version of this somehow broke so reverted.

@alexpott #3006625: 'stylesheets-remove' test is broken wasn't backported to 8.6.x, hence the fail. Since that is a test only fix, they can probably both be backported.

@lendude thanks! Done what you suggested. Tests in sync across dev and bug branches is helpful :)