The unit tests of System's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.

CommentFileSizeAuthor
#12 2807939-12.patch2.61 KBsvendecabooter
#6 2807939-3.patch2.57 KBerozqba
#4 2807939-2.patch2.57 KBerozqba
#2 2807939-1.patch2.57 KBerozqba

Comments

quietone created an issue. See original summary.

erozqba’s picture

erozqba commented
StatusFileSize
new 2807939-1.patch2.57 KB
erozqba’s picture

erozqba commented
Status: Active » Needs review
erozqba’s picture

erozqba commented
StatusFileSize
new 2807939-2.patch2.57 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2807939-2.patch, failed testing.

erozqba’s picture

erozqba commented
StatusFileSize
new 2807939-3.patch2.57 KB
erozqba’s picture

erozqba commented
Status: Needs work » Needs review
quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

Thank you!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2807939-3.patch, failed testing.

quietone’s picture

quietone commented
Status: Needs work » Reviewed & tested by the community

No, the tests passed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

See #2807879-14: Convert Contact's Migrate source tests to new base class - let's use better array keys to make it easier to understand what is going on.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs work » Needs review
StatusFileSize
new 2807939-12.patch2.61 KB

Updated the patch to have more informative keys (next to descriptive comments) as suggested by alexpott

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

Thank again, svendecabooter !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6523934 to 8.3.x and fc2c8d0 to 8.2.x. Thanks!

  • alexpott committed 6523934 on 8.3.x 
    Issue #2807939 by erozqba, svendecabooter: Convert System's Migrate...

  • alexpott committed fc2c8d0 on 8.2.x 
    Issue #2807939 by erozqba, svendecabooter: Convert System's Migrate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.