In #2791119: Write meaningful Migrate source tests, we introduced a new base class for testing Migrate source plugins. It's now time to do the grunt work of converting the existing core tests to this base class. I propose we do this by module, each in their own issue, linked by this meta. A lot of these tests will be very easy to convert -- perhaps even novice-level.

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Issue summary: View changes
dawehner’s picture

Was this approach discussed with the committers? Usually they try to avoid too many issues doing conceptually the same. An alternative approach is to find conceptual similar changes and make issues per them.

phenaproxima’s picture

I guess I assumed it was OK because Migrate has done it before -- last year we had separate issues, plus a meta, to move all modules' individual migrations into the actual modules, rather than keeping them all under the Migrate Drupal umbrella.

dawehner’s picture

I would recommend to talk with a maintainer before you know, causing another round of pain.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

Status: Active » Fixed

Woohoo! All tasks completed.

Thanks to all those who pitched in!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.