The unit tests of Menu_link_content's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.

CommentFileSizeAuthor
#8 2807905-8.patch12.18 KBsvendecabooter
#3 2807905-3.patch12.12 KBsvendecabooter

Comments

quietone created an issue. See original summary.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Assigned: Unassigned » svendecabooter
svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Assigned: svendecabooter » Unassigned
Status: Active » Needs review
StatusFileSize
new 2807905-3.patch12.12 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Glorious work. Thank you, @svendecabooter!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2807905-3.patch, failed testing.

quietone’s picture

quietone commented
Status: Needs work » Reviewed & tested by the community

No, really the tests are passing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

See #2807879-14: Convert Contact's Migrate source tests to new base class - let's use better array keys to make it easier to understand what is going on.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs work » Needs review
StatusFileSize
new 2807905-8.patch12.18 KB

Updated the patch to have more informative keys (next to descriptive comments) as suggested by alexpott

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Back to RTBC!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed e672f61 to 8.3.x and 6418429 to 8.2.x. Thanks!

  • alexpott committed e672f61 on 8.3.x 
    Issue #2807905 by svendecabooter: Convert Menu_link_content's Migrate...

  • alexpott committed 6418429 on 8.2.x 
    Issue #2807905 by svendecabooter: Convert Menu_link_content's Migrate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.