Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The unit tests of Contact's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.
Comment | File | Size | Author |
---|---|---|---|
#15 | 2807879-15.patch | 6.45 KB | alexpott |
#15 | 12-15-interdiff.txt | 2.43 KB | alexpott |
#12 | interdiff-2807879-10-12.txt | 1.4 KB | phenaproxima |
#12 | 2807879-12.patch | 6.31 KB | phenaproxima |
#10 | interdiff-2807879-6-10.txt | 1.12 KB | peaton |
Comments
Comment #2
peatonComment #3
peatonComment #4
peatonComment #5
peatonWhoops screwed some whitespace and one of the tests. Fixed.
Comment #6
phenaproximaNice! Removing extraneous use statements, plus a couple of whitespace nitpicks. Great work, @peaton!
Comment #10
peatonComment #12
phenaproximaOut, damn spot!
Comment #13
quietone CreditAttribution: quietone as a volunteer commentedThank you, peaton and phenapromixa.
Comment #14
alexpottPersonally I find the new tests actually hard to work out what is going on. At the very least we should have comments as to what is being set up. Maybe we can use the keys to be more informative - I'm not sure that PHPUnit cares about them.
Comment #15
alexpottSomething like this...
Comment #16
quietone CreditAttribution: quietone as a volunteer commentedthx alexpott.
Comment #17
alexpottComment #18
alexpottCommitted and pushed 515a55e to 8.3.x and 02abbfe to 8.2.x. Thanks!