The unit tests of Contact's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.

CommentFileSizeAuthor
#15 2807879-15.patch6.45 KBalexpott
#15 12-15-interdiff.txt2.43 KBalexpott
#12 interdiff-2807879-10-12.txt1.4 KBphenaproxima
#12 2807879-12.patch6.31 KBphenaproxima
#10 interdiff-2807879-6-10.txt1.12 KBpeaton
#10 2807879-10.patch6.23 KBpeaton
#6 interdiff-2807879-5-6.txt1.37 KBphenaproxima
#6 2807879-6.patch6.04 KBphenaproxima
#5 2807879-5.patch6.15 KBpeaton
#3 2807879-3.patch6.19 KBpeaton

Comments

quietone created an issue. See original summary.

peaton’s picture

peaton
she/her
commented
Assigned: Unassigned » peaton
peaton’s picture

peaton
she/her
commented
StatusFileSize
new 2807879-3.patch6.19 KB
peaton’s picture

peaton
she/her
commented
Assigned: peaton » Unassigned
Status: Active » Needs review
peaton’s picture

peaton
she/her
commented
StatusFileSize
new 2807879-5.patch6.15 KB

Whoops screwed some whitespace and one of the tests. Fixed.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2807879-6.patch6.04 KB
new interdiff-2807879-5-6.txt1.37 KB

Nice! Removing extraneous use statements, plus a couple of whitespace nitpicks. Great work, @peaton!

The last submitted patch, 5: 2807879-5.patch, failed testing.

The last submitted patch, 3: 2807879-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: 2807879-6.patch, failed testing.

peaton’s picture

peaton
she/her
commented
Status: Needs work » Needs review
StatusFileSize
new 2807879-10.patch6.23 KB
new interdiff-2807879-6-10.txt1.12 KB

Status: Needs review » Needs work

The last submitted patch, 10: 2807879-10.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2807879-12.patch6.31 KB
new interdiff-2807879-10-12.txt1.4 KB

Out, damn spot!

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

Thank you, peaton and phenapromixa.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Personally I find the new tests actually hard to work out what is going on. At the very least we should have comments as to what is being set up. Maybe we can use the keys to be more informative - I'm not sure that PHPUnit cares about them.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 12-15-interdiff.txt2.43 KB
new 2807879-15.patch6.45 KB

Something like this...

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

thx alexpott.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 515a55e to 8.3.x and 02abbfe to 8.2.x. Thanks!

  • alexpott committed 515a55e on 8.3.x 
    Issue #2807879 by peaton, phenaproxima, alexpott: Convert Contact's...

  • alexpott committed 02abbfe on 8.2.x 
    Issue #2807879 by peaton, phenaproxima, alexpott: Convert Contact's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.