Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The unit tests of Block_content's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | interdiff.txt | 1.69 KB | quietone |
| #12 | 2807863-12.patch | 5.29 KB | quietone |
| #4 | interdiff.txt | 608 bytes | quietone |
| #4 | 2807863-4.patch | 5.21 KB | quietone |
| #2 | 2807863-2.patch | 5.21 KB | phenaproxima |
Comments
Comment #2
phenaproximaComment #4
quietone CreditAttribution: quietone as a volunteer commentedFixed namespace.
Comment #5
phenaproximaThose PHP 7 fails are a total WTF, but I think they're going to be preventing RTBC for fear of breaking HEAD. Not sure how to verify (or deny) them, though...we probably need input from someone more knowledgeable than myself.
Comment #6
quietone CreditAttribution: quietone as a volunteer commentedFor what its worth, the two failing tests, UrlConversionTest and.phpPathAliasTest.php pass locally on Php7 and Maria10.
Comment #7
phenaproximaNot only that, but #2807879: Convert Contact's Migrate source tests to new base class is also having the exact same PHP 7 failures...even though it was passing on PHP 7 before, right here on Drupal CI. I saw it with my very own peepers.
I call shenanigans. Unfortunately I cannot RTBC since I wrote the original patch, but if I could, I would.
Comment #8
chipway CreditAttribution: chipway at Chipway commentedThese test failures on PHP 7 seems independent of your patch.
On my local PHP 7 + MySQL 5.7, no failure for UrlConversionTest.php and LinkGenerationTest.php, and couldn't run PathAliasTest.php. Same failures on #2807879: Convert Contact's Migrate source tests to new base class
Comment #9
quietone CreditAttribution: quietone as a volunteer commentedTests are passing again.
Comment #10
chipway CreditAttribution: chipway at Chipway commentedI have read 2807863-4.patch.
It applies well on 8.3.x, remove the 2 old files and add the 2 new ones as intended.
So it fixes this issue, stays in scope and I RTBC it.
Comment #11
alexpottSee #2807879-14: Convert Contact's Migrate source tests to new base class - let's use better array keys to make it easier to understand what is going on.
Comment #12
quietone CreditAttribution: quietone as a volunteer commentedOK.
Comment #13
chipway CreditAttribution: chipway at Chipway commentedThanks @alexpott for your hint and @quietone for the new 2807863-12.patch.
It applies well on 8.3.x, fixes this issue, includes #11 comment hint, stays in scope. Tests passes locally on my PHP7.
So I just wait for the confirmation thru bot tests to RTBC it.
Comment #14
chipway CreditAttribution: chipway at Chipway commentedBot tests OK.
Comment #15
alexpottCommitted and pushed 7d70af5 to 8.3.x and b840cbc to 8.2.x. Thanks!