Image Upload

then it will get uploaded to wherever drupal product should theoretically be uploading its images (so for me everything will go under "store/pics" which i setup in as the location of the 'field_images')?

Correct. The files should be moved to the location specified in the field settings.

so if the zip file did have the pics organized by subfolders, they would be ignored and everything is uploaded under "store/pics" correct?

Correct. If you have folders in the zip archive you'll need to specify a relative path in the field_image column but they'll be placed directly in the store/pics folder.

It's also OK for the spreadsheet to reference an image that is not included in the zip archive if the image already exists in the destination.

Cool got it, thanks!

actually one more question. if its 1 row in the import file per product/variation, for each variation pretend I have 5 pics (that I will upload at the same time via a zip file). How do those 5 paths get added to the 1 variation row in Excel?
Should i use comma separation or another format Commerce XLS Import recognizes?

You should use commas to separate the file paths.

That applies to any multi-value fields you have. It uses str_getcsv() when the field is multi-value so you can comma-separate and quote things in a standard way.

just tested.
The rows without images got imported but rows with images paths could not.
I do see my images file got uploaded to: sites/default/files/product_images.zip

No unusual errors in php logs, just Commerse XLS Import errors like:
field_images: File store-temp/pics/IMG_2171.jpg does not exist.
tried non-relative path:
field_images: File /store-temp/pics/IMG_2171.jpg does not exist

Then tried without the zip file and upload directly to server be4 the import and got this:
field_images: File /home/username/theWebsite.com/sites/default/files/store-temp/pics/IMG_2171.jpg does not exist.
also tried these with the files already pre-uploaded to server:
sites/default/files/store-temp/pics/IMG_2171.jpg and
/sites/default/files/store-temp/pics/IMG_2171.jpg and
store-temp/pics/IMG_2171.jpg and
/store-temp/pics/IMG_2171.jpg

Any ideas (I'd prefer to use the zip upload) on why erroring?
Let me know and Ill give it a shot..

Also instead of using zip, if i just uploaded directly to the server, and use the server path... I assume it should be a temporary path so Drupal can name the file appropriately, like if my field_images filepath/filename is:
store/pics/nid-[commerce-product:field-product-node:0:nid]/product-id-[commerce-product:product-id]/[commerce-product:title]-[file:fid].[file:ffp-extension-original]
then it theoretically would move it from my store-temp/pics directory referenced in my Excel to my store/pics directory correct?

Is your zip file flat or does it have directories?

images.zip
|-- picture1.jpg
|-- picture2.jpg
|-- picture3.jpg

If the archive is flat, use "picture1.jpg", "picture2.jpg" in the import. You need to tell the import where to find the image when it extracts the zip archive and it'll look up the destination appropriate to the field it's being added to.

images.zip
|-- picture1.jpg
|-- foo
    |-- picture2.jpg
|-- bar
     |-- baz
         |-- picture3.jpg

If you have directories in the zip archive you should be able to do "picture1.jpg", "foo/picture2.jpg", "bar/baz/picture3.jpg". This does not have to match the structure of the directories where the images will be moved to.

Was using the relative structure. Not sure why it didn't work let me just try flat files in the zip and retest

hey tbradbury,
I tried with relative paths (like when i was doing store-temp/pics/IMG_2171.jpg above ) and still no luck.
Tried with flat files in the zip (with no subfolders), and that worked.
Guess you can close unless worried relative paths still an issue.

Thanks for reporting back, armyofda12mnkeys.

I see that the issue is in CommerceXlsImportSettings::imagePath() - it only scans for files in the directory the images were extracted, not in sub-directories.

Having reviewed it I think the function was doing a lot of things that aren't necessary. This patch cuts that down to just file_exists(). I think it'll solve your problem if you still want your zip file to have sub-directories.

Changing status to run tests.

Its a bit further.
I tried uploading the zip file which has a directory structure of store/pics/test101.jpg, store/pics/test102.jpg, etc in the zip file.
and in the Commerce Excel template I had the same relative fields in field_images: store/pics/test101.jpg, etc

My Variation's field_images field is set to put the file to:

File (Field) Path settings

File path:
store/pics/product-id-[commerce-product:product-id]/
File name:
[commerce-product:title]-[file:fid].[file:ffp-extension-original]

I get this error when I try to Validate:
field_images: Unable to move file store/pics/test101.jpg to public://store/pics/store/pics/test101.jpg.

Looks like maybe its not even trying to move it under the appropriate place.
Any further ideas to debug?

I think this change to the patch will fix that - it should try to move the image to public://store/pics/test101.jpg instead of public://store/pics/store/pics/test101.jpg

Hey tbradbury,
I tested both going from:
store/pics/test101.jpg (in the zip)
to
store/pics/test101.jpg on the server and it works now (validates and imports correctly).

also tried FileField Paths for my field_images, so going from:
store/pics/test101.jpg (in the zip)
to:
store/pics/product-id-[commerce-product:product-id]/[commerce-product:title]-[file:fid].[file:ffp-extension-original]
and that also works great! Thanks!

Running tests

Oh wait, tests aren't set up haha. Are we running them via Travis CI now?

Add patch to resolve the issue related to copying files over from tmp location.

Rolled the previous two patches from #13 & #18 together against the latest dev.