Replace non-test usage of t() with injected service

Adding the patch for the issue

This will fix the errors

+++ b/core/modules/outside_in/src/Form/SystemBrandingOffCanvasForm.php
@@ -34,9 +38,12 @@ class SystemBrandingOffCanvasForm extends PluginFormBase implements ContainerInj
+  public function __construct(ConfigFactoryInterface $config_factory, TranslationInterface $string_translation) {
     $this->configFactory = $config_factory;
+    $this->stringTranslation = $string_translation;

This is a BC break, but as the module is in alpha then who cares ;)

1. +++ b/core/modules/outside_in/outside_in.module
   @@ -17,11 +19,11 @@
    function outside_in_help($route_name, RouteMatchInterface $route_match) {
   ...
   +      $output = '<h3>' . $this->t('About') . '</h3>';
   +      $output .= '<p>' . $this->t('The Settings Tray module provides an \'edit mode\' in which clicking on a block opens a slide-out tray which allows configuration to be altered without leaving the page.For more information, see the <a href=":outside-in-documentation">online documentation for the Settings Tray module</a>.', [':outside-in-documentation' => 'https://www.drupal.org/documentation/modules/outside_in']) . '</p>';
   +      $output .= '<h3>' . $this->t('Uses') . '</h3>';
   ...
   +      $output .= '<dt>' . $this->t('Editing blocks on the same page in the slide-out tray') . '</dt>';
   

   Unfortunately, hooks don't have a $this, much less $this->t(). So either leave the global t() or use $translation = \Drupal::translation() to get the service, and then call $translation->t().

2. +++ b/core/modules/outside_in/src/Form/SystemBrandingOffCanvasForm.php
   @@ -15,6 +17,8 @@
   +  use StringTranslationTrait;
   
   @@ -34,9 +38,12 @@ class SystemBrandingOffCanvasForm extends PluginFormBase implements ContainerInj
   +    $this->stringTranslation = $string_translation;
   

   StringTranslationTrait has a setStringTranslation() method we should use during the constructor.

@Mile23 Thanks for review code.

@naveenvalecha Please Suggest me issues in 2806983-11.patch

#11, Please do test on local before posting, Did you even test the patch on d.o.

+++ b/core/modules/outside_in/outside_in.module
@@ -17,11 +19,11 @@
-      $output = '<h3>' . t('About') . '</h3>';
-      $output .= '<p>' . t('The Settings Tray module provides an \'edit mode\' in which clicking on a block opens a slide-out tray which allows configuration to be altered without leaving the page.For more information, see the <a href=":outside-in-documentation">online documentation for the Settings Tray module</a>.', [':outside-in-documentation' => 'https://www.drupal.org/documentation/modules/outside_in']) . '</p>';
-      $output .= '<h3>' . t('Uses') . '</h3>';
+      $output = '<h3>' . $this->t('About') . '</h3>';
+      $output .= '<p>' . $this->t('The Settings Tray module provides an \'edit mode\' in which clicking on a block opens a slide-out tray which allows configuration to be altered without leaving the page.For more information, see the <a href=":outside-in-documentation">online documentation for the Settings Tray module</a>.', [':outside-in-documentation' => 'https://www.drupal.org/documentation/modules/outside_in']) . '</p>';
+      $output .= '<h3>' . $this->t('Uses') . '</h3>';
       $output .= '<dl>';
-      $output .= '<dt>' . t('Editing blocks on the same page in the slide-out tray') . '</dt>';
+      $output .= '<dt>' . $this->t('Editing blocks on the same page in the slide-out tray') . '</dt>';
       $output .= '</dl>';

Unreleated changes.

#12.2
yup nice spot :)

@naveenvalecha Thanks
Next time improve my coding.

Here is the patch please review

corrected the patch as mentioned in #12

Kindly review.
Thanks!

Thanks. :-)

+++ b/core/modules/outside_in/src/Form/SystemBrandingOffCanvasForm.php
@@ -34,9 +38,12 @@ class SystemBrandingOffCanvasForm extends PluginFormBase implements ContainerInj
+    setStringTranslation($string_translation);

The trait adds setStringTranslation() to $this, so it would be $this->setStringTranslation($string_translation);

Hi @Mile23,

Thanks for reviewing my patch.

Have corrected the minor change as mentioned in #24.

Kindly review.
Thanks!

+++ b/core/modules/outside_in/src/Cache/Context/OutsideInCacheContext.php
@@ -34,7 +34,7 @@ public function __construct(OutsideInManagerInterface $outside_in_manager) {
+    return $this->t('Settings Tray');

This will make the test fail b/c the $this->t() function will not be available here.

@minakshiPh Settings needs work because of #27

Hi @tedbow,

Change mentioned in #27 is done and attached the new patch.

Kindly review.
Thanks!

Looking really good - reviewed and tested. It should perhaps be considered to do something about the skipping tests?

Starting test 'Drupal\Tests\outside_in\FunctionalJavascript\OffCanvasTest::testOffCanvasLinks'.
S
Starting test 'Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest::testBlocks'.
S

Thank you for your work on cleaning up Drupal core's use of deprecated APIs!

In order to deprecate APIs in a maintainable way, converting deprecated uses should be replaced across all of core for a given kind of usage, rather than in individual modules or files. Such issues should also always be part of an overall plan to ensure all usages are removed, rather than standalone patches. Such a plan may already exist for t() so this issue should probably be closed in favor of that.

For background information on why we usually will not commit cleanups that aren't scoped in that way, see the core issue scope guidelines. See #2575081: [policy, no patch] Use E_USER_DEPRECATED in Drupal 8 minor releases for more information on how we plan to manage deprecations in the future.

Contributing to the overall plan above will help ensure that your cleanups for core's deprecated code improve core in a maintainable and minimally disruptive way.

For this issue, we should start by replacing non-test t() usages in all classes where the translation trait or service is already available. This can be done with a script. We would then have a followup to inject the service in classes where it is not already available and convert usages there. Finally, we should have a separate issue to discuss the use of t() in tests. We probably should close this issue as a duplicate, but setting to needs work for now so that contributors see this information. Thanks!

You might want to help contribute to this issue instead: #2549805: Remove all usage of FormattableMarkup in tests apart from explicit tests of that API

Closing as per @xjm comments in #33

Such a plan may already exist for t() so this issue should probably be closed in favor of that.

If anybody knows of such as issue please link to it from here.

@xjm: For this issue, we should start by replacing non-test t() usages in all classes where the translation trait or service is already available. This can be done with a script.

Can't be done with a script. Someone is welcome to prove me wrong, however.

I don't think the larger-scope issue exists since I couldn't find it. I'm re-opening and re-scoping here, since we already have a patch here.

Fixed this with 9.2.x

Closing as duplicate of #3122912: t() calls should be avoided , use $this->t() instead in Form Builders